Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 10261019: Disable some flaky IndexedDB browser tests. (Closed)

Created:
8 years, 7 months ago by dgrogan
Modified:
8 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Disable some flaky IndexedDB browser tests. BUG=123685 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134672

Patch Set 1 #

Total comments: 7

Patch Set 2 : fix style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M content/browser/in_process_webkit/indexed_db_layout_browsertest.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Josh, could you review this?
8 years, 7 months ago (2012-04-30 21:50:38 UTC) #1
jsbell
lgtm with formatting nits https://chromiumcodereview.appspot.com/10261019/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (left): https://chromiumcodereview.appspot.com/10261019/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc#oldcode104 content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:104: // http://crbug.com/120924 Is 120924 a ...
8 years, 7 months ago (2012-04-30 22:48:53 UTC) #2
dgrogan
https://chromiumcodereview.appspot.com/10261019/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (left): https://chromiumcodereview.appspot.com/10261019/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc#oldcode104 content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:104: // http://crbug.com/120924 On 2012/04/30 22:48:54, jsbell wrote: > Is ...
8 years, 7 months ago (2012-05-01 00:46:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/10261019/4001
8 years, 7 months ago (2012-05-01 00:46:20 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 03:56:59 UTC) #5
Change committed as 134672

Powered by Google App Engine
This is Rietveld 408576698