Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10261017: Change a few EXPECT_TRUE to ASSERT_TRUE so it fails instead of crashing. (Closed)

Created:
8 years, 7 months ago by Nicolas Sylvain
Modified:
8 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Change a few EXPECT_TRUE to ASSERT_TRUE so it fails instead of crashing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/app_process_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Sylvain
8 years, 7 months ago (2012-04-30 21:07:14 UTC) #1
jam
lgtm
8 years, 7 months ago (2012-04-30 21:20:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nsylvain@chromium.org/10261017/1
8 years, 7 months ago (2012-04-30 21:35:51 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 23:27:58 UTC) #4 
Change committed as 134631

Powered by Google App Engine
This is Rietveld 408576698