Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10261016: NaCl: Synchronise build.scons file with Gyp file (Closed)

Created:
8 years, 7 months ago by Mark Seaborn
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Synchronise build.scons file with Gyp file I moved sel_ldr_launcher_chrome.cc into the Chromium repo in r134552 but I forgot to update build.scons. This update is necessary for removing sel_ldr_launcher_chrome.cc from the NaCl repo because it ensures that the 'launch_nacl_process' variable (which module_ppapi.cc assigns to) will be defined. (The alternative would be to conditionalise the assignment of 'launch_nacl_process' in module_ppapi.cc.) BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750 TEST=NaCl's Scons build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/native_client/src/trusted/plugin/build.scons View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
8 years, 7 months ago (2012-04-30 19:52:15 UTC) #1
bbudge
lgtm
8 years, 7 months ago (2012-04-30 20:59:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10261016/1
8 years, 7 months ago (2012-04-30 21:00:26 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 22:36:41 UTC) #4
Change committed as 134619

Powered by Google App Engine
This is Rietveld 408576698