[protector] Homepage UI polishing.

chrome/browser/protector/homepage_change_unittest.cc

Index: chrome/browser/protector/homepage_change_unittest.cc
diff --git a/chrome/browser/protector/homepage_change_unittest.cc b/chrome/browser/protector/homepage_change_unittest.cc
index cfea686369125679e6ec2e0f8d24119bf31d0231..001812d9463c7ce2d0fd273528719c6023de2b77 100644
--- a/chrome/browser/protector/homepage_change_unittest.cc
+++ b/chrome/browser/protector/homepage_change_unittest.cc
@@ -9,7 +9,9 @@
 #include "chrome/browser/protector/base_setting_change.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
+#include "grit/generated_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
 
 namespace protector {
 
@@ -60,4 +62,57 @@ TEST_F(HomepageChangeTest, InitAndDiscard) {
   EXPECT_EQ(kHomepage2, prefs_->GetString(prefs::kHomePage));
 }
 
+TEST_F(HomepageChangeTest, DiscardButtonCaptionsSameSetting) {
+  // New and backup setting have the same URL (or both are NTP).
+
+  // NTP can be represented both by an empty URL or a |homepage_is_ntp| flag.
+  // NTP -> NTP.
+  scoped_ptr<BaseSettingChange> change(
+      CreateHomepageChange(kHomepage1, true, true, kHomepage2, true, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  string16 generic_caption(l10n_util::GetStringUTF16(IDS_KEEP_SETTING));
+  EXPECT_EQ(generic_caption, change->GetDiscardButtonText());
+
+  // NTP -> NTP.
+  change.reset(
+      CreateHomepageChange("", false, true, kHomepage2, true, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  EXPECT_EQ(generic_caption, change->GetDiscardButtonText());
+
+  // NTP -> NTP.
+  change.reset(
+      CreateHomepageChange(kHomepage1, true, true, "", false, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  EXPECT_EQ(generic_caption, change->GetDiscardButtonText());
+
+  // kHomepage1 -> kHomepage1.
+  change.reset(
+      CreateHomepageChange(kHomepage1, false, true, kHomepage1, false, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  EXPECT_EQ(generic_caption, change->GetDiscardButtonText());
+}
+
+TEST_F(HomepageChangeTest, DiscardButtonCaptionsDifferentSettings) {
+  // New and backup settings differ.
+
+  // NTP -> kHomepage2.
+  scoped_ptr<BaseSettingChange> change(
+      CreateHomepageChange(kHomepage1, true, true, kHomepage2, false, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  string16 generic_caption(l10n_util::GetStringUTF16(IDS_KEEP_SETTING));
+  EXPECT_NE(generic_caption, change->GetDiscardButtonText());
+
+  // kHomepage1 -> NTP.
+  change.reset(
+      CreateHomepageChange(kHomepage1, false, true, kHomepage2, true, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  EXPECT_NE(generic_caption, change->GetDiscardButtonText());
+
+  // kHomepage1 -> kHomepage2.
+  change.reset(
+      CreateHomepageChange(kHomepage1, false, true, kHomepage2, false, true));
+  ASSERT_TRUE(change->Init(&profile_));
+  EXPECT_NE(generic_caption, change->GetDiscardButtonText());
+}
+
 }  // namespace protector