Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 10260032: Missing .exe in windows build. (Closed)

Created:
8 years, 7 months ago by noelallen1
Modified:
8 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Missing .exe in windows build. The scons build is failing to copy the extension when putting exe in the tools output directory. Added batch file to simplify tries on Windows. BUG=125762 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134798

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 3 chunks +11 lines, -1 line 0 comments Download
A native_client_sdk/src/sdktry.bat View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
also, can you merge to HEAD? I don't want to lose all my changes to ...
8 years, 7 months ago (2012-05-01 17:24:18 UTC) #1
noelallen1
8 years, 7 months ago (2012-05-01 18:06:10 UTC) #2
binji
8 years, 7 months ago (2012-05-01 18:40:29 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698