Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/browser/autocomplete/autocomplete_field_trial.cc

Issue 10260020: Make Omnibox HistoryURL Provider always aggressive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit test. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_field_trial.cc
diff --git a/chrome/browser/autocomplete/autocomplete_field_trial.cc b/chrome/browser/autocomplete/autocomplete_field_trial.cc
index 44ae72977e5ac0ce0dd8e87b1fe14f7fc06eca9d..d262892d3751fd03399a2a7984d08fe0b124e85b 100644
--- a/chrome/browser/autocomplete/autocomplete_field_trial.cc
+++ b/chrome/browser/autocomplete/autocomplete_field_trial.cc
@@ -13,20 +13,12 @@
namespace {
// Field trial names.
-static const char kAggressiveHUPFieldTrialName[] =
- "OmniboxAggressiveHistoryURLProvider";
static const char kDisallowInlineHQPFieldTrialName[] =
"OmniboxDisallowInlineHQP";
static const char kSuggestFieldTrialName[] = "OmniboxSearchSuggest";
// Field trial experiment probabilities.
-// For aggressive History URL Provider field trial, put 50% ( = 50/100 )
-// of the users in the aggressive experiment group.
-const base::FieldTrial::Probability kAggressiveHUPFieldTrialDivisor = 100;
-const base::FieldTrial::Probability
- kAggressiveHUPFieldTrialExperimentFraction = 50;
-
// For inline History Quick Provider field trial, put 10% ( = 10/100 )
// of the users in the disallow-inline experiment group.
const base::FieldTrial::Probability kDisallowInlineHQPFieldTrialDivisor = 100;
@@ -42,9 +34,6 @@ const int kSuggestFieldTrialNumberOfGroups = 20;
// Though they are not literally "const", they are set only once, in
// Activate() below.
-// Field trial ID for the aggressive History URL Provider experiment group.
-int aggressive_hup_experiment_group = 0;
-
// Field trial ID for the disallow-inline History Quick Provider
// experiment group.
int disallow_inline_hqp_experiment_group = 0;
@@ -62,21 +51,12 @@ void AutocompleteFieldTrial::Activate() {
// trust the omnibox. Hence, to create the field trials we require
// that field trials can be made sticky.
if (base::FieldTrialList::IsOneTimeRandomizationEnabled()) { // sticky trials
- // Create aggressive History URL Provider field trial.
- // Make it expire on August 1, 2012.
- scoped_refptr<base::FieldTrial> trial(
- base::FieldTrialList::FactoryGetFieldTrial(
- kAggressiveHUPFieldTrialName, kAggressiveHUPFieldTrialDivisor,
- "Standard", 2012, 8, 1, NULL));
- trial->UseOneTimeRandomization();
- aggressive_hup_experiment_group = trial->AppendGroup("Aggressive",
- kAggressiveHUPFieldTrialExperimentFraction);
-
// Create inline History Quick Provider field trial.
// Make it expire on November 8, 2012.
- trial = base::FieldTrialList::FactoryGetFieldTrial(
+ scoped_refptr<base::FieldTrial> trial(
+ base::FieldTrialList::FactoryGetFieldTrial(
kDisallowInlineHQPFieldTrialName, kDisallowInlineHQPFieldTrialDivisor,
- "Standard", 2012, 11, 8, NULL);
+ "Standard", 2012, 11, 8, NULL));
trial->UseOneTimeRandomization();
disallow_inline_hqp_experiment_group = trial->AppendGroup("DisallowInline",
kDisallowInlineHQPFieldTrialExperimentFraction);
@@ -97,20 +77,6 @@ void AutocompleteFieldTrial::Activate() {
trial->AppendGroup(base::StringPrintf("%d", i), 1);
}
-bool AutocompleteFieldTrial::InAggressiveHUPFieldTrial() {
- return base::FieldTrialList::TrialExists(kAggressiveHUPFieldTrialName);
-}
-
-bool AutocompleteFieldTrial::InAggressiveHUPFieldTrialExperimentGroup() {
- if (!base::FieldTrialList::TrialExists(kAggressiveHUPFieldTrialName))
- return false;
-
- // Return true if we're in the aggressive experiment group.
- const int group = base::FieldTrialList::FindValue(
- kAggressiveHUPFieldTrialName);
- return group == aggressive_hup_experiment_group;
-}
-
bool AutocompleteFieldTrial::InDisallowInlineHQPFieldTrial() {
return base::FieldTrialList::TrialExists(kDisallowInlineHQPFieldTrialName);
}

Powered by Google App Engine
This is Rietveld 408576698