Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10260016: Standardize formatting of certificate authority trust overlay. (Closed)

Created:
8 years, 7 months ago by kevers
Modified:
8 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Standardize formatting of certificate authority trust overlay. BUG=102482 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134611

Patch Set 1 #

Patch Set 2 : Fix title of the certificate manager dialog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/certificate_edit_ca_trust_overlay.html View 1 chunk +24 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler2.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevers
Hi Evan, Can you please take a look at this CL.
8 years, 7 months ago (2012-04-30 17:24:01 UTC) #1
Evan Stade
before and after screenshots would be nice. While you're at it, can you change the ...
8 years, 7 months ago (2012-04-30 19:16:40 UTC) #2
kevers
Title updated for the certificate manager. Screenshots in your inbox.
8 years, 7 months ago (2012-04-30 19:35:07 UTC) #3
Evan Stade
lgtm, thanks
8 years, 7 months ago (2012-04-30 20:16:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10260016/3001
8 years, 7 months ago (2012-04-30 20:23:21 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 22:09:40 UTC) #6
Change committed as 134611

Powered by Google App Engine
This is Rietveld 408576698