Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10260013: Style: move non-simple getters from hacker_style to CamelCase. (Closed)

Created:
8 years, 7 months ago by gavinp
Modified:
8 years, 7 months ago
Reviewers:
dominich
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : follow through more meaningfully on the hacker_style change... #

Total comments: 2

Patch Set 3 : actually make the change I said I would... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 11 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
WDYT?
8 years, 7 months ago (2012-04-30 14:44:44 UTC) #1
dominich
http://codereview.chromium.org/10260013/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/10260013/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode819 chrome/browser/prerender/prerender_browsertest.cc:819: ASSERT_TRUE(GetPrerenderManager()); consider caching the result of GetPrerenderManager in a ...
8 years, 7 months ago (2012-04-30 14:52:16 UTC) #2
gavinp
Good points, both of them.
8 years, 7 months ago (2012-04-30 15:12:25 UTC) #3
dominich
LGTM modulo more replacements of GetModel() with |model| http://codereview.chromium.org/10260013/diff/4001/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/10260013/diff/4001/chrome/browser/prerender/prerender_browsertest.cc#newcode1434 chrome/browser/prerender/prerender_browsertest.cc:1434: if ...
8 years, 7 months ago (2012-04-30 15:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10260013/4
8 years, 7 months ago (2012-04-30 15:48:03 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 17:23:25 UTC) #6
Change committed as 134549

Powered by Google App Engine
This is Rietveld 408576698