Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2839)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 10260003: Remove another instance of a dcheck when 'begin' is set incorrectly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/page_load_histograms.cc
===================================================================
--- chrome/renderer/page_load_histograms.cc (revision 134480)
+++ chrome/renderer/page_load_histograms.cc (working copy)
@@ -256,9 +256,12 @@
PLT_HISTOGRAM("PLT.CommitToFirstPaint", first_paint - commit);
}
if (!first_paint_after_load.is_null()) {
- DCHECK(begin <= first_paint_after_load);
- PLT_HISTOGRAM("PLT.BeginToFirstPaintAfterLoad",
- first_paint_after_load - begin);
+ // 'first_paint_after_load' can be before 'begin' for an unknown reason.
+ // See bug http://crbug.com/125273 for details.
+ if (begin <= first_paint_after_load) {
+ PLT_HISTOGRAM("PLT.BeginToFirstPaintAfterLoad",
+ first_paint_after_load - begin);
+ }
DCHECK(commit <= first_paint_after_load);
PLT_HISTOGRAM("PLT.CommitToFirstPaintAfterLoad",
first_paint_after_load - commit);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698