Added a new automation hook ExecuteJavascriptInOOBEWebUI() to execute javascript prior to login on…

Added a new automation hook ExecuteJavascriptInOOBEWebUI() to permit executing abitrary javascript prior to login on chromeos.

Change-Id: If96d94bb22ac5bd25fa4ab1e3a4c3ba52ea47370

BUG=chromium-os:29466, chromium-os:20709
TEST=functional/chromeos_login.py (testExecuteJavascriptInOOBEWebUI)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134666

[Nirnimesh, 2012-04-27 22:46:38]

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.cc:2171:
handler_map["ExecuteJavascriptInLogin"] =
move to OS_CHROMEOS section below

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:992: // Executes
javascript in the specified frame in the login page. Uses the
login page -> login page on chromeos

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:992: // Executes
javascript in the specified frame in the login page. Uses the
Move to OS_CHROMEOS section below

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:3216: def ExecuteJavascriptInLogin(self, js,
frame_xpath=''):
I recommend appending 'WebUI' to the name

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:3217: """Executes a script in the specified
frame of a tab.
fix

[craigdh, 2012-04-27 23:29:50]

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.cc:2171:
handler_map["ExecuteJavascriptInLogin"] =
On 2012/04/27 22:46:38, Nirnimesh wrote:
> move to OS_CHROMEOS section below

Done.

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:992: // Executes
javascript in the specified frame in the login page. Uses the
On 2012/04/27 22:46:38, Nirnimesh wrote:
> Move to OS_CHROMEOS section below

Done.

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:992: // Executes
javascript in the specified frame in the login page. Uses the
On 2012/04/27 22:46:38, Nirnimesh wrote:
> login page -> login page on chromeos

Done.

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:3216: def ExecuteJavascriptInLogin(self, js,
frame_xpath=''):
On 2012/04/27 22:46:38, Nirnimesh wrote:
> I recommend appending 'WebUI' to the name

Done.

https://chromiumcodereview.appspot.com/10257015/diff/3005/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:3217: """Executes a script in the specified
frame of a tab.
On 2012/04/27 22:46:38, Nirnimesh wrote:
> fix

Done.

[dennis_jeffrey, 2012-04-28 16:44:05]

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
chrome/browser/automation/testing_automation_provider_chromeos.cc:966: const
UserManager* user_manager = UserManager::Get();
move this down below right before line 977

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
chrome/browser/automation/testing_automation_provider_chromeos.cc:991:
controller->login_display_host());
is it safe to assume 'controller' exists here?  You had added a check at line
293 above.

[craigdh, 2012-04-30 18:41:32]

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
File chrome/browser/automation/testing_automation_provider_chromeos.cc (right):

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
chrome/browser/automation/testing_automation_provider_chromeos.cc:966: const
UserManager* user_manager = UserManager::Get();
On 2012/04/28 16:44:05, dennis_jeffrey wrote:
> move this down below right before line 977

Done.

https://chromiumcodereview.appspot.com/10257015/diff/10002/chrome/browser/aut...
chrome/browser/automation/testing_automation_provider_chromeos.cc:991:
controller->login_display_host());
On 2012/04/28 16:44:05, dennis_jeffrey wrote:
> is it safe to assume 'controller' exists here?  You had added a check at line
> 293 above.

Done.

[Nirnimesh, 2012-04-30 18:57:07]

Since this automation hook can be used to inject js in any OOBE webui, not just
login one, please update the name and docstring accordingly, and also reference
BUG=chromium-os:20709 

LGTM

https://chromiumcodereview.appspot.com/10257015/diff/13006/chrome/test/pyauto...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10257015/diff/13006/chrome/test/pyauto...
chrome/test/pyautolib/pyauto.py:3216: def ExecuteJavascriptInLoginWebUI(self,
js, frame_xpath=''):
Login -> OOBE

https://chromiumcodereview.appspot.com/10257015/diff/13006/chrome/test/pyauto...
chrome/test/pyautolib/pyauto.py:3217: """Executes a script in the specified
frame of a pre-login WebUI.
pre-login -> OOBE

https://chromiumcodereview.appspot.com/10257015/diff/13006/chrome/test/pyauto...
chrome/test/pyautolib/pyauto.py:3219: By default, execute the script in the top
frame of the login window. This
Remove reference to 'login'. Mention: Can be used to execute js in login frame
when it's showing.

[dennis_jeffrey, 2012-04-30 21:51:00]

LGTM

[commit-bot: I haz the power, 2012-05-01 00:03:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10257015/16007

[commit-bot: I haz the power, 2012-05-01 00:06:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10257015/16007

[commit-bot: I haz the power, 2012-05-01 02:07:56]

Change committed as 134666