chrome/browser/extensions/api/web_request/web_request_api.cc - Issue 10257006: Move Declarative Web Request API out of experimental and make it a feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 10257006: Move Declarative Web Request API out of experimental and make it a feature (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.cc ('k') | chrome/chrome_renderer.gypi » ('j') | chrome/common/extensions/api/_permission_features.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc

index 3c1e586a18ef7041ae83c94ad9412b67b5979c37..cb92c73e1c0d8db253d83ca6bea75fbaee0af7ad 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc

@@ -1373,6 +1373,9 @@ bool ExtensionWebRequestEventRouter::ProcessDeclarativeRules(

base::Time start = base::Time::Now();

+ // TODO(battre): Annotate deltas with extension IDs, so that we can

+ // - Sort deltas by precedence

+ // - Check whether extensions have host permissions.

std::list<linked_ptr<helpers::EventResponseDelta> > result =

rules_registry_->CreateDeltas(request, request_stage);