Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 10257006: Move Declarative Web Request API out of experimental and make it a feature (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_permission_set.h" 5 #include "chrome/common/extensions/extension_permission_set.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/json/json_file_value_serializer.h" 8 #include "base/json/json_file_value_serializer.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 TEST(ExtensionPermissionsTest, PermissionMessages) { 554 TEST(ExtensionPermissionsTest, PermissionMessages) {
555 // Ensure that all permissions that needs to show install UI actually have 555 // Ensure that all permissions that needs to show install UI actually have
556 // strings associated with them. 556 // strings associated with them.
557 ExtensionAPIPermissionSet skip; 557 ExtensionAPIPermissionSet skip;
558 558
559 // These are considered "nuisance" or "trivial" permissions that don't need 559 // These are considered "nuisance" or "trivial" permissions that don't need
560 // a prompt. 560 // a prompt.
561 skip.insert(ExtensionAPIPermission::kAppNotifications); 561 skip.insert(ExtensionAPIPermission::kAppNotifications);
562 skip.insert(ExtensionAPIPermission::kBrowsingData); 562 skip.insert(ExtensionAPIPermission::kBrowsingData);
563 skip.insert(ExtensionAPIPermission::kContextMenus); 563 skip.insert(ExtensionAPIPermission::kContextMenus);
564 skip.insert(ExtensionAPIPermission::kDeclarative);
564 skip.insert(ExtensionAPIPermission::kIdle); 565 skip.insert(ExtensionAPIPermission::kIdle);
565 skip.insert(ExtensionAPIPermission::kNotification); 566 skip.insert(ExtensionAPIPermission::kNotification);
566 skip.insert(ExtensionAPIPermission::kUnlimitedStorage); 567 skip.insert(ExtensionAPIPermission::kUnlimitedStorage);
567 skip.insert(ExtensionAPIPermission::kStorage); 568 skip.insert(ExtensionAPIPermission::kStorage);
568 skip.insert(ExtensionAPIPermission::kTts); 569 skip.insert(ExtensionAPIPermission::kTts);
569 570
570 // TODO(erikkay) add a string for this permission. 571 // TODO(erikkay) add a string for this permission.
571 skip.insert(ExtensionAPIPermission::kBackground); 572 skip.insert(ExtensionAPIPermission::kBackground);
572 573
573 skip.insert(ExtensionAPIPermission::kClipboardWrite); 574 skip.insert(ExtensionAPIPermission::kClipboardWrite);
574 575
575 // The cookie permission does nothing unless you have associated host 576 // The cookie permission does nothing unless you have associated host
576 // permissions. 577 // permissions.
577 skip.insert(ExtensionAPIPermission::kCookie); 578 skip.insert(ExtensionAPIPermission::kCookie);
578 579
579 // The ime, proxy, and webRequest permissions are warned as part of host 580 // The ime, proxy, and webRequest permissions are warned as part of host
580 // permission checks. 581 // permission checks.
581 skip.insert(ExtensionAPIPermission::kInput); 582 skip.insert(ExtensionAPIPermission::kInput);
582 skip.insert(ExtensionAPIPermission::kProxy); 583 skip.insert(ExtensionAPIPermission::kProxy);
583 skip.insert(ExtensionAPIPermission::kWebRequest); 584 skip.insert(ExtensionAPIPermission::kWebRequest);
584 skip.insert(ExtensionAPIPermission::kWebRequestBlocking); 585 skip.insert(ExtensionAPIPermission::kWebRequestBlocking);
586 skip.insert(ExtensionAPIPermission::kDeclarativeWebRequest);
587
585 588
586 // This permission requires explicit user action (context menu handler) 589 // This permission requires explicit user action (context menu handler)
587 // so we won't prompt for it for now. 590 // so we won't prompt for it for now.
588 skip.insert(ExtensionAPIPermission::kFileBrowserHandler); 591 skip.insert(ExtensionAPIPermission::kFileBrowserHandler);
589 592
590 // This permission requires explicit user action (shortcut) so we don't 593 // This permission requires explicit user action (shortcut) so we don't
591 // prompt for it. 594 // prompt for it.
592 skip.insert(ExtensionAPIPermission::kKeybinding); 595 skip.insert(ExtensionAPIPermission::kKeybinding);
593 596
594 // If you've turned on the experimental command-line flag, we don't need 597 // If you've turned on the experimental command-line flag, we don't need
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 AddPattern(&non_empty_extent, "http://www.google.com/*"); 1095 AddPattern(&non_empty_extent, "http://www.google.com/*");
1093 1096
1094 perm_set = new ExtensionPermissionSet( 1097 perm_set = new ExtensionPermissionSet(
1095 empty_apis, non_empty_extent, empty_extent); 1098 empty_apis, non_empty_extent, empty_extent);
1096 EXPECT_FALSE(perm_set->IsEmpty()); 1099 EXPECT_FALSE(perm_set->IsEmpty());
1097 1100
1098 perm_set = new ExtensionPermissionSet( 1101 perm_set = new ExtensionPermissionSet(
1099 empty_apis, empty_extent, non_empty_extent); 1102 empty_apis, empty_extent, non_empty_extent);
1100 EXPECT_FALSE(perm_set->IsEmpty()); 1103 EXPECT_FALSE(perm_set->IsEmpty());
1101 } 1104 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698