Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issue 10257003: Enable Prerender API browsertests (Closed)

Created:
8 years, 8 months ago by gavinp
Modified:
8 years, 7 months ago
Reviewers:
dominich
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Enable Prerender API browsertests Due to the way the prerender API was staged, it landed in Chrome before it was implemented in WebKit. This patch enables the browsertests that depend on that API. BUG=84236 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138013

Patch Set 1 #

Patch Set 2 : rebase to trunk #

Total comments: 6

Patch Set 3 : remediate to dominich review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 4 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
Dominic, https://bugs.webkit.org/show_bug.cgi?id=85005 has landed. This test is now fresh; I'll launch a try once the ...
8 years, 7 months ago (2012-05-15 10:02:52 UTC) #1
dominich
LG modulo nits also, remove <a href="REPLACE_WITH_DESTINATION_URL">Link To Click</a> from the .html file referenced as ...
8 years, 7 months ago (2012-05-15 15:52:03 UTC) #2
gavinp
TY for your review dominic! http://codereview.chromium.org/10257003/diff/1002/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/10257003/diff/1002/chrome/browser/prerender/prerender_browsertest.cc#newcode988 chrome/browser/prerender/prerender_browsertest.cc:988: IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, On 2012/05/15 15:52:04, ...
8 years, 7 months ago (2012-05-18 02:59:52 UTC) #3
dominich
lgtm
8 years, 7 months ago (2012-05-18 14:41:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10257003/6002
8 years, 7 months ago (2012-05-19 01:08:00 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-19 02:30:42 UTC) #6
Change committed as 138013

Powered by Google App Engine
This is Rietveld 408576698