Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 10256010: Exclude a new net test from cf net tests. (Closed)

Created:
8 years, 8 months ago by erikwright (departed)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, robertshield, grt+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit
Visibility:
Public.

Description

Exclude a new net test from cf net tests. This test is not designed to work under Chrome Frame net test configuration. BUG=None TEST=Tests pass on Webkit waterfall and Chromium try bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
erikwright (departed)
PTAL.
8 years, 8 months ago (2012-04-27 19:59:14 UTC) #1
erikwright (departed)
Can I get a review from someone please? Gimme an L! Gimme a G! ...
8 years, 8 months ago (2012-04-28 01:13:49 UTC) #2
grt (UTC plus 2)
On 2012/04/28 01:13:49, erikwright wrote: > Can I get a review from someone please? > ...
8 years, 8 months ago (2012-04-28 01:18:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10256010/1
8 years, 8 months ago (2012-04-28 01:57:33 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-04-28 03:50:12 UTC) #5
Change committed as 134441

Powered by Google App Engine
This is Rietveld 408576698