Issue 10255018: Linux: Use the same safe downloads logic as Windows. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10255018: Linux: Use the same safe downloads logic as Windows. (try 2) (Closed)

Created:
8 years, 7 months ago by Lei Zhang

Modified:
8 years, 7 months ago

Reviewers:
asanka

CC:
chromium-reviews, rdsmith+dwatch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Linux: Use the same safe downloads logic as Windows. (try 2) BUG=none TEST=none First attempt: http://codereview.chromium.org/10241007/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134438

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -43 lines)			Patch
M	chrome/browser/download/download_util.cc	View	1	10 chunks	+37 lines, -23 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_paths.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_paths_internal.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_paths_linux.cc	View		2 chunks	+7 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

VS2010 did not like the last CL. Basically iostream in VS2010 includes cmath. So to ...

8 years, 7 months ago (2012-04-28 00:54:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10255018/6001

8 years, 7 months ago (2012-04-28 01:52:41 UTC) #3

Change committed as 134438