Fixed failure to add language in language settings page.

chrome/browser/resources/options2/language_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var List = cr.ui.List;
   /** @const */ var ListItem = cr.ui.ListItem;
@@ skipping 52 matching lines @@
   /**
    * Gets information of a language from the given language code.
    * @param {string} languageCode Language code (ex. "fr").
    */
   LanguageList.getLanguageInfoFromLanguageCode = function(languageCode) {
     // Build the language code to language info dictionary at first time.
     if (!this.languageCodeToLanguageInfo_) {
       this.languageCodeToLanguageInfo_ = {};
       var languageList = templateData.languageList;
       for (var i = 0; i < languageList.length; i++) {
-        this.languageCodeToLanguageInfo_[languageCode] = languageList[i];
+        this.languageCodeToLanguageInfo_[language.code] = languageList[i];

[csilv, 2012/04/27 21:29:48]

I'm confused by this change, can you explain it?

[Danh Nguyen, 2012/04/27 21:38:52]

The parameter languageCode is a language code of the language to be looked up. 
It doesn't change in this function's scope.  Meanwhile, language.code is the
language code of the current language when we iterate the language list in the
for loop.  So it changes inside the loop.  Without this change, the mapping from
language code to language info will have only one entry, indexed by
languageCode, which is incorrect.

       }
     }
 
     return this.languageCodeToLanguageInfo_[languageCode];
   }
 
   /**
    * Returns true if the given language code is valid.
    * @param {string} languageCode Language code (ex. "fr").
    */
@@ skipping 374 matching lines @@
       }
       return filteredLanguageCodes;
     },
   };
 
   return {
     LanguageList: LanguageList,
     LanguageListItem: LanguageListItem
   };
 });