Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10255017: Fixed failure to add language in language settings page. (Closed)

Created:
8 years, 8 months ago by Danh Nguyen
Modified:
8 years, 7 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews), James Hawkins, Sheridan Rawlins
Visibility:
Public.

Description

Fixed failure to add language in language settings page. BUG=125323 TEST=browser_tests --gtest_filter=WebUIBidiCheckerBrowserTestRTL.TestSettingsLanguageOptionsPage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134427

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed error from eearlier edit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/resources/options2/language_list.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler2.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Danh Nguyen
Hi Chris, This CL fixes a P0 for M20. Could you help to review it ...
8 years, 8 months ago (2012-04-27 21:22:41 UTC) #1
csilv
http://codereview.chromium.org/10255017/diff/1/chrome/browser/resources/options2/language_list.js File chrome/browser/resources/options2/language_list.js (right): http://codereview.chromium.org/10255017/diff/1/chrome/browser/resources/options2/language_list.js#newcode73 chrome/browser/resources/options2/language_list.js:73: this.languageCodeToLanguageInfo_[language.code] = languageList[i]; I'm confused by this change, can ...
8 years, 8 months ago (2012-04-27 21:29:48 UTC) #2
Danh Nguyen
Thanks Chris. Please see my explanation below. Danh http://codereview.chromium.org/10255017/diff/1/chrome/browser/resources/options2/language_list.js File chrome/browser/resources/options2/language_list.js (right): http://codereview.chromium.org/10255017/diff/1/chrome/browser/resources/options2/language_list.js#newcode73 chrome/browser/resources/options2/language_list.js:73: this.languageCodeToLanguageInfo_[language.code] ...
8 years, 8 months ago (2012-04-27 21:38:52 UTC) #3
Danh Nguyen
I made an error while cleaning up the changes. Please ignore my previous email. I'll ...
8 years, 8 months ago (2012-04-27 21:41:47 UTC) #4
Danh Nguyen
Hi Chris, I've just got home and uploaded a new patch. Could you take a ...
8 years, 7 months ago (2012-04-27 23:30:44 UTC) #5
csilv
lgtm
8 years, 7 months ago (2012-04-27 23:49:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danhn@chromium.org/10255017/10001
8 years, 7 months ago (2012-04-28 00:31:58 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-04-28 02:20:31 UTC) #8
Change committed as 134427

Powered by Google App Engine
This is Rietveld 408576698