Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 10255007: Clamp events before they are sent to EventExecutors. (Closed)

Created:
8 years, 8 months ago by Wez
Modified:
8 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Clamp events before they are sent to EventExecutors. * MouseInputFilter is moved from remoting/client/ to remoting/protocol/. * ClientSession now implements clamping using MouseInputFilter. * EventExecutors no longer drop out-of-bounds events. BUG=118511 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134594

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add missing include. #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -377 lines) Patch
D remoting/client/mouse_input_filter.h View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/client/mouse_input_filter.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D remoting/client/mouse_input_filter_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/client_session.h View 3 chunks +6 lines, -1 line 0 comments Download
M remoting/host/client_session.cc View 3 chunks +8 lines, -16 lines 0 comments Download
M remoting/host/event_executor_linux.cc View 9 chunks +8 lines, -34 lines 0 comments Download
M remoting/host/event_executor_mac.cc View 1 2 7 chunks +15 lines, -26 lines 0 comments Download
A + remoting/protocol/mouse_input_filter.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + remoting/protocol/mouse_input_filter.cc View 5 chunks +9 lines, -11 lines 0 comments Download
A + remoting/protocol/mouse_input_filter_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/remoting.gyp View 1 2 6 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Wez
PTAL. http://codereview.chromium.org/10255007/diff/1/remoting/host/client_session.cc File remoting/host/client_session.cc (right): http://codereview.chromium.org/10255007/diff/1/remoting/host/client_session.cc#newcode65 remoting/host/client_session.cc:65: mouse_input_filter_.set_input_size(capturer_->size_most_recent()); I'd like to get rid of the ...
8 years, 8 months ago (2012-04-27 17:39:50 UTC) #1
Jamie
lgtm
8 years, 8 months ago (2012-04-27 18:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10255007/1
8 years, 8 months ago (2012-04-27 22:53:37 UTC) #3
commit-bot: I haz the power
Try job failure for 10255007-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 23:24:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10255007/6002
8 years, 7 months ago (2012-04-28 05:21:55 UTC) #5
commit-bot: I haz the power
Try job failure for 10255007-6002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-04-28 05:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10255007/12003
8 years, 7 months ago (2012-04-30 18:52:32 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 20:54:46 UTC) #8
Change committed as 134594

Powered by Google App Engine
This is Rietveld 408576698