Port some files in chrome/common to Linux....

Port some files in chrome/common to Linux.

BUG=3649

[please use my chromium address, 2008-11-10 17:02:09]

Not tested on Windows. Please test it on a trybot if possible.

[please use my chromium address, 2008-11-11 21:02:33]

On 2008/11/10 17:02:09, phajdan.jr wrote:
> Not tested on Windows. Please test it on a trybot if possible.

Updated to hopefully fix compile issue.

[please use my chromium address, 2008-11-19 19:58:39]

On 2008/11/11 21:02:33, phajdan.jr wrote:
> On 2008/11/10 17:02:09, phajdan.jr wrote:
> > Not tested on Windows. Please test it on a trybot if possible.
> 
> Updated to hopefully fix compile issue.

*ping*

[Evan Martin, 2008-11-20 22:38:31]

http://codereview.chromium.org/10255/diff/401/404
File chrome/common/pref_service.cc (right):

http://codereview.chromium.org/10255/diff/401/404#newcode423
Line 423: while ((existing_obs = it.GetNext())) {
May as well make the != NULL test explicit, so that nobody else comes along and
"cleans up" and breaks this again.

http://codereview.chromium.org/10255/diff/401/403
File chrome/common/time_format.cc (right):

http://codereview.chromium.org/10255/diff/401/403#newcode217
Line 217: string16 result_utf16 = WideToUTF16(WriteInto(&formatted, capacity));
I'm not sure this works, exactly.  The previous code had time_string write into
formatted, but this code has time_string extract into result_utf16.  I think you
should just have the extract call below and then return
UTF16ToWide(result_utf16).

[please use my chromium address, 2008-11-21 17:34:00]

On 2008/11/20 22:38:31, Evan Martin wrote:
> http://codereview.chromium.org/10255/diff/401/404
> File chrome/common/pref_service.cc (right):
> 
> http://codereview.chromium.org/10255/diff/401/404#newcode423
> Line 423: while ((existing_obs = it.GetNext())) {
> May as well make the != NULL test explicit, so that nobody else comes along
and
> "cleans up" and breaks this again.

Done here and in one other place.

> http://codereview.chromium.org/10255/diff/401/403
> File chrome/common/time_format.cc (right):
> 
> http://codereview.chromium.org/10255/diff/401/403#newcode217
> Line 217: string16 result_utf16 = WideToUTF16(WriteInto(&formatted,
capacity));
> I'm not sure this works, exactly.  The previous code had time_string write
into
> formatted, but this code has time_string extract into result_utf16.  I think
you
> should just have the extract call below and then return
> UTF16ToWide(result_utf16).

Ooops. Indeed, my previous code was totally nonsensical. Now it should be right.

[Evan Martin, 2008-11-21 20:51:34]

r5848