Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10254028: Add native debugging support to android content shell. (Closed)

Created:
8 years, 7 months ago by John Grabowski
Modified:
8 years, 7 months ago
Reviewers:
Ted C, Satish, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, nilesh, Yaron
Visibility:
Public.

Description

Add native debugging support to android content shell. How to native debug: - apply the patch listed in the code review description - adb_run_content_shell - gdb_content_shell - attach Eclipse; continue - now boom! SEGV in gdb. Sadly the native library crashes while loading so it's not registered with gdb yet (e.g no symbols or stack). This CL also adds in a file that got lost (testing/android/README.chromium). BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135652

Patch Set 1 #

Patch Set 2 : update description #

Total comments: 10

Patch Set 3 : satish feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -9 lines) Patch
A build/android/gdb_content_shell View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +8 lines, -2 lines 0 comments Download
M content/shell/android/content_shell_apk.xml View 2 chunks +28 lines, -7 lines 0 comments Download
A testing/android/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
John Grabowski
+ jam for OWNERS + cc nilesh; we probably want to use the same pattern ...
8 years, 7 months ago (2012-04-28 02:47:58 UTC) #1
John Grabowski
Oh -- here's the patch mentioned in the CL description. diff --git a/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java b/content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java index ...
8 years, 7 months ago (2012-04-28 02:48:41 UTC) #2
jam
rubberstamp lgtm
8 years, 7 months ago (2012-04-30 16:03:22 UTC) #3
Satish
https://chromiumcodereview.appspot.com/10254028/diff/2001/build/android/gdb_content_shell File build/android/gdb_content_shell (right): https://chromiumcodereview.appspot.com/10254028/diff/2001/build/android/gdb_content_shell#newcode32 build/android/gdb_content_shell:32: adb shell kill $pid indentation https://chromiumcodereview.appspot.com/10254028/diff/2001/build/android/gdb_content_shell#newcode34 build/android/gdb_content_shell:34: adb shell ...
8 years, 7 months ago (2012-05-03 10:28:03 UTC) #4
John Grabowski
https://chromiumcodereview.appspot.com/10254028/diff/2001/build/android/gdb_content_shell File build/android/gdb_content_shell (right): https://chromiumcodereview.appspot.com/10254028/diff/2001/build/android/gdb_content_shell#newcode32 build/android/gdb_content_shell:32: adb shell kill $pid On 2012/05/03 10:28:03, Satish wrote: ...
8 years, 7 months ago (2012-05-07 12:40:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/10254028/9002
8 years, 7 months ago (2012-05-07 13:35:27 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-07 16:25:59 UTC) #7
Change committed as 135652

Powered by Google App Engine
This is Rietveld 408576698