Issue 10254027: chromeos: Rename LoginHtmlDialog to LoginWebDialog.

Issue 10254027: chromeos: Rename LoginHtmlDialog to LoginWebDialog. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
stevenjb, whywhat

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Rename LoginHtmlDialog to LoginWebDialog. This is a follow up to r133991. R=stevenjb@chromium.org,avayvod@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134775

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -297 lines)			Patch
M	chrome/browser/chromeos/login/help_app_launcher.h	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/help_app_launcher.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	chrome/browser/chromeos/login/login_html_dialog.h	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	chrome/browser/chromeos/login/login_html_dialog.cc	View	1 chunk	+0 lines, -133 lines	0 comments	Download
A +	chrome/browser/chromeos/login/login_web_dialog.h	View	4 chunks	+16 lines, -16 lines	0 comments	Download
A +	chrome/browser/chromeos/login/login_web_dialog.cc	View	3 chunks	+27 lines, -27 lines	0 comments	Download
M	chrome/browser/chromeos/login/proxy_settings_dialog.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/proxy_settings_dialog.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stevenjb

I'm not a particularly good candidate to review this, I'd get someone from chromeos/login/OWNERS.

8 years, 8 months ago (2012-04-28 02:54:29 UTC) #2

tfarina

On 2012/04/28 02:54:29, stevenjb (chromium) wrote: > I'm not a particularly good candidate to review ...

8 years, 7 months ago (2012-04-28 12:48:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10254027/1

8 years, 7 months ago (2012-04-30 10:47:16 UTC) #5

commit-bot: I haz the power

Presubmit check for 10254027-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 7 months ago (2012-04-30 10:47:26 UTC) #6

tfarina

On Mon, Apr 30, 2012 at 7:47 AM, <commit-bot@chromium.org> wrote: > CQ is trying da ...

8 years, 7 months ago (2012-04-30 16:43:21 UTC) #7

whywhat

8 years, 7 months ago (2012-04-30 16:53:57 UTC) #8

Ok. Sorry for that. I thought it would be faster.

On 2012/04/30 16:43:21, tfarina wrote:
> On Mon, Apr 30, 2012 at 7:47 AM,  <mailto:commit-bot@chromium.org> wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/tfarina%40chromium.org/10254027/1
> >
> Please, no need to send this to CQ. I commit this manually.
> 
> Thanks.
> >
> > http://codereview.chromium.org/10254027/
> 
> 
> 
> -- 
> Thiago

Expand Messages | Collapse Messages