Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10254023: Fix unit-tests compilation on Android. (Closed)

Created:
8 years, 8 months ago by Jay Civelli
Modified:
8 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Fix unit-tests compilation on Android. The Android compiler does not realize a var is initialized and complains about it. Initializing the variable earlier so it stops complaining. BUG=None TEST=unit_tests should compile on Android. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/sync/glue/session_model_associator.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jay Civelli
8 years, 8 months ago (2012-04-27 22:14:58 UTC) #1
Nicolas Zea
lgtm
8 years, 8 months ago (2012-04-27 22:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10254023/1
8 years, 8 months ago (2012-04-28 00:03:47 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 02:17:31 UTC) #4
Change committed as 134426

Powered by Google App Engine
This is Rietveld 408576698