Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10254014: Don't do field trials if Instant is explicitly enabled. (Closed)

Created:
8 years, 8 months ago by sreeram
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Don't do field trials if Instant is explicitly enabled. http://crrev.com/134073 removed the check for prefs::kInstantEnabledOnce for some field trial modes. So it became possible for Instant to be explicitly enabled, and yet for IsHiddenExperiment() to return true (which would cause incorrect logic in InstantController::Update() and other places). Fix this by checking that prefs::kInstantEnabled is not set. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/instant/instant_field_trial.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sreeram
Please review.
8 years, 8 months ago (2012-04-27 19:11:46 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-27 20:34:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/10254014/1
8 years, 7 months ago (2012-04-28 22:16:46 UTC) #3
commit-bot: I haz the power
Try job failure for 10254014-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=24229 Step "update" is always ...
8 years, 7 months ago (2012-04-28 22:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/10254014/1
8 years, 7 months ago (2012-04-28 23:14:25 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-04-29 00:45:53 UTC) #6
Change committed as 134486

Powered by Google App Engine
This is Rietveld 408576698