Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10254011: Add flag to experiments to force high DPI mode. (Closed)

Created:
8 years, 8 months ago by flackr
Modified:
8 years, 7 months ago
Reviewers:
oshima, sky, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sadrul, ben+watch_chromium.org, Fady Samuel
Visibility:
Public.

Description

Add flag to experiments to force high DPI mode. This adds --default-device-scale-factor to flags and makes this flag override the aura monitor scale factor and forces enable_viewport on web contents. BUG=124412 TEST=When flag is enabled, web contents are drawn at 2x and aura monitor scale factor is set to 2x. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134741

Patch Set 1 #

Total comments: 2

Patch Set 2 : Verify that StringToInt succeeded. #

Patch Set 3 : Merge with master. #

Patch Set 4 : Remove monitor_manager change made redundant by oshima's patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
flackr
Hi guys, this change makes default-device-scale-factor the one-stop flag for testing other scale factors and ...
8 years, 8 months ago (2012-04-27 18:15:54 UTC) #1
sky
LGTM http://codereview.chromium.org/10254011/diff/1/ui/aura/monitor_manager.cc File ui/aura/monitor_manager.cc (right): http://codereview.chromium.org/10254011/diff/1/ui/aura/monitor_manager.cc#newcode52 ui/aura/monitor_manager.cc:52: base::StringToInt(CommandLine::ForCurrentProcess()->GetSwitchValueASCII( check return value.
8 years, 8 months ago (2012-04-27 19:44:45 UTC) #2
flackr
http://codereview.chromium.org/10254011/diff/1/ui/aura/monitor_manager.cc File ui/aura/monitor_manager.cc (right): http://codereview.chromium.org/10254011/diff/1/ui/aura/monitor_manager.cc#newcode52 ui/aura/monitor_manager.cc:52: base::StringToInt(CommandLine::ForCurrentProcess()->GetSwitchValueASCII( On 2012/04/27 19:44:46, sky wrote: > check return ...
8 years, 7 months ago (2012-04-30 14:05:15 UTC) #3
oshima
lgtm FYI: http://codereview.chromium.org/10255020/
8 years, 7 months ago (2012-04-30 17:46:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10254011/4002
8 years, 7 months ago (2012-04-30 23:39:25 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/browser/about_flags.cc. While running patch -p1 --forward --force; patching file chrome/browser/about_flags.cc ...
8 years, 7 months ago (2012-04-30 23:39:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10254011/6003
8 years, 7 months ago (2012-05-01 00:01:14 UTC) #7
commit-bot: I haz the power
Presubmit check for 10254011-6003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-01 00:01:42 UTC) #8
flackr
+piman, for content/renderer. PTAL, thanks!
8 years, 7 months ago (2012-05-01 00:42:54 UTC) #9
piman
lgtm
8 years, 7 months ago (2012-05-01 00:48:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10254011/6003
8 years, 7 months ago (2012-05-01 01:06:21 UTC) #11
commit-bot: I haz the power
Try job failure for 10254011-6003 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-01 01:35:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10254011/6003
8 years, 7 months ago (2012-05-01 16:32:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10254011/10003
8 years, 7 months ago (2012-05-01 17:20:43 UTC) #14
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 19:02:27 UTC) #15
Change committed as 134741

Powered by Google App Engine
This is Rietveld 408576698