Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 10253021: Restore context menus to hosted app sites. (Closed)

Created:
8 years, 7 months ago by benwells
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Restore context menus to hosted app sites. This broke as a result of r134028, where we iterate all RVHs associated with an extension instead of just ExtensionHosts. BUG=125306 TEST=Test hosted app menus, extension popup menus and platform app popups work correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134627

Patch Set 1 #

Patch Set 2 : Fixed comment #

Patch Set 3 : Removed unneeded code #

Total comments: 1

Patch Set 4 : Logging to see output on try bots #

Patch Set 5 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 4 4 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
http://codereview.chromium.org/10253021/diff/1004/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (left): http://codereview.chromium.org/10253021/diff/1004/chrome/browser/tab_contents/render_view_context_menu.cc#oldcode1901 chrome/browser/tab_contents/render_view_context_menu.cc:1901: // Don't enable the web inspector if JavaScript is ...
8 years, 7 months ago (2012-04-28 01:26:06 UTC) #1
benwells
Tests are happy again.
8 years, 7 months ago (2012-04-28 04:45:54 UTC) #2
asargent_no_longer_on_chrome
LGTM
8 years, 7 months ago (2012-04-30 17:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10253021/9003
8 years, 7 months ago (2012-04-30 21:23:48 UTC) #4
Mihai Parparita -not on Chrome
On 2012/04/30 21:23:48, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 7 months ago (2012-04-30 21:24:24 UTC) #5
commit-bot: I haz the power
Change committed as 134627
8 years, 7 months ago (2012-04-30 23:08:59 UTC) #6
benwells
8 years, 7 months ago (2012-05-01 04:07:24 UTC) #7
On 2012/04/30 23:08:59, I haz the power (commit-bot) wrote:
> Change committed as 134627

Thanks Mihai!

Powered by Google App Engine
This is Rietveld 408576698