Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10248006: [Sync] - add some debug info to track down issue 120709 (Closed)

Created:
8 years, 8 months ago by lipalani1
Modified:
8 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Add some debug info to track down issue 120709. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134433

Patch Set 1 #

Patch Set 2 : For review. #

Patch Set 3 : #

Patch Set 4 : For review. #

Total comments: 6

Patch Set 5 : for review. #

Patch Set 6 : For submitting. #

Patch Set 7 : For submitting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 1 2 3 4 5 6 4 chunks +33 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lipalani1
Please review.
8 years, 8 months ago (2012-04-27 01:16:56 UTC) #1
Nicolas Zea
http://codereview.chromium.org/10248006/diff/2004/chrome/browser/sync/glue/non_frontend_data_type_controller.cc File chrome/browser/sync/glue/non_frontend_data_type_controller.cc (right): http://codereview.chromium.org/10248006/diff/2004/chrome/browser/sync/glue/non_frontend_data_type_controller.cc#newcode199 chrome/browser/sync/glue/non_frontend_data_type_controller.cc:199: if (start_association_called_) { I suspect TSAN is going to ...
8 years, 8 months ago (2012-04-27 17:23:52 UTC) #2
lipalani1
Please review. TSAN, I believe should not be an issue because we dont throw any ...
8 years, 8 months ago (2012-04-27 17:43:20 UTC) #3
Nicolas Zea
lgtm
8 years, 8 months ago (2012-04-27 17:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/10248006/14088
8 years, 8 months ago (2012-04-27 19:12:58 UTC) #5
commit-bot: I haz the power
Try job failure for 10248006-14088 (retry) on linux_rel for step "unit_tests". It's a second try, ...
8 years, 8 months ago (2012-04-27 20:02:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/10248006/20003
8 years, 8 months ago (2012-04-28 01:20:50 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 02:54:03 UTC) #8
Change committed as 134433

Powered by Google App Engine
This is Rietveld 408576698