media/filters/video_renderer_base.h - Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_base.h

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised on comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/video_renderer_base.h

diff --git a/media/filters/video_renderer_base.h b/media/filters/video_renderer_base.h

index 2746ccb98da0e155383670477fbed0cbc380a0c2..b42b8d94ed5a89884843a5fcac3547845d5aed18 100644

--- a/media/filters/video_renderer_base.h

+++ b/media/filters/video_renderer_base.h

@@ -74,8 +74,9 @@ class MEDIA_EXPORT VideoRendererBase

void PutCurrentFrame(scoped_refptr<VideoFrame> frame);

private:

- // Callback from the video decoder delivering decoded video frames.

- void FrameReady(scoped_refptr<VideoFrame> frame);

+ // Callback from the video decoder delivering decoded video frames and

+ // reporting video decoder status.

+ void FrameReady(VideoDecoder::Status status, scoped_refptr<VideoFrame> frame);

// Helper method that schedules an asynchronous read from the decoder as long

// as there isn't a pending read and we have capacity.

« media/base/filters.cc ('K') | « media/filters/video_frame_generator.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »