content/renderer/media/capture_video_decoder.cc - Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/capture_video_decoder.cc

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised on comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/capture_video_decoder.cc

diff --git a/content/renderer/media/capture_video_decoder.cc b/content/renderer/media/capture_video_decoder.cc

index 0309c0484b04caf40c186ae2f837e11bd41d9c42..3623c1de68b0d4bfc87b55d5cf16a6e8fed29378 100644

--- a/content/renderer/media/capture_video_decoder.cc

+++ b/content/renderer/media/capture_video_decoder.cc

@@ -279,7 +279,5 @@ void CaptureVideoDecoder::OnBufferReadyOnDecoderThread(

void CaptureVideoDecoder::DeliverFrame(

const scoped_refptr<media::VideoFrame>& video_frame) {

// Reset the callback before running to protect against reentrancy.

- ReadCB read_cb = read_cb_;

- read_cb_.Reset();

- read_cb.Run(video_frame);

+ base::ResetAndReturn(&read_cb_).Run(kOk, video_frame);

}

« no previous file with comments | « no previous file | content/renderer/media/capture_video_decoder_unittest.cc » ('j') | media/base/filters.cc » ('J')