content/renderer/media/rtc_video_decoder.cc - Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/capture_video_decoder_unittest.cc ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | media/base/filters.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index dc3ffe1e720a96a2fe8dc757b8deb72a5ac347f9..1dc67d2c7cfdc0ecd9cd59c40d56694b39268f3b 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -107,7 +107,7 @@ void RTCVideoDecoder::Flush(const base::Closure& callback) {

scoped_refptr<media::VideoFrame> video_frame =

media::VideoFrame::CreateBlackFrame(visible_size_.width(),

visible_size_.height());

- read_cb.Run(video_frame);

+ read_cb.Run(video_frame, kOk);

}

VideoDecoder::Flush(callback);

@@ -224,6 +224,6 @@ bool RTCVideoDecoder::RenderFrame(const cricket::VideoFrame* frame) {

CopyUPlane(frame->GetUPlane(), frame->GetUPitch(), uv_rows, video_frame);

CopyVPlane(frame->GetVPlane(), frame->GetVPitch(), uv_rows, video_frame);

- read_cb.Run(video_frame);

+ read_cb.Run(video_frame, kOk);

return true;

}

« no previous file with comments | « content/renderer/media/capture_video_decoder_unittest.cc ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | media/base/filters.h » ('J')