Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: media/filters/video_renderer_base.h

Issue 10248002: Report VideoDecoder status through ReadCB instead of through FilterHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_renderer_base.h
diff --git a/media/filters/video_renderer_base.h b/media/filters/video_renderer_base.h
index 2746ccb98da0e155383670477fbed0cbc380a0c2..af75de1ce065187b1ac94fb907bda73dba39c25a 100644
--- a/media/filters/video_renderer_base.h
+++ b/media/filters/video_renderer_base.h
@@ -74,8 +74,11 @@ class MEDIA_EXPORT VideoRendererBase
void PutCurrentFrame(scoped_refptr<VideoFrame> frame);
private:
- // Callback from the video decoder delivering decoded video frames.
- void FrameReady(scoped_refptr<VideoFrame> frame);
+ // Callback from the video decoder delivering decoded video frames and
+ // reporting video decoder status. If |status| is not VideoDecoder::kOk,
+ // it means some error has occurred in video decoder. In this case, |frame|
+ // should be NULL.
scherkus (not reviewing) 2012/04/27 18:27:56 nit: this documentation should be in the definitio
xhwang 2012/04/27 23:22:30 Done.
+ void FrameReady(scoped_refptr<VideoFrame> frame, VideoDecoder::Status status);
// Helper method that schedules an asynchronous read from the decoder as long
// as there isn't a pending read and we have capacity.

Powered by Google App Engine
This is Rietveld 408576698