Issue 10248001: Explicitly track the time source type in base/profiler/alternate_timer.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10248001: Explicitly track the time source type in base/profiler/alternate_timer.h (Closed)

Created:
8 years, 8 months ago by Ilya Sherman

Modified:
8 years, 8 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Explicitly track the time source type in base/profiler/alternate_timer.h We were previously implicitly tracking the time source as either default or tcmalloc-based; but as we add more time sources (e.g. cpu time), we'll want to have explicit tracking for this. BUG=none TEST=none TBR=jar@chromium.org (Recommit of [ https://chromiumcodereview.appspot.com/10225017/ ]) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134187

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	base/allocator/allocator_shim.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/profiler/alternate_timer.h	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	base/profiler/alternate_timer.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10248001/1

8 years, 8 months ago (2012-04-26 22:45:43 UTC) #1

Change committed as 134187