Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 10246004: Clear uniforms (Closed)

Created:
8 years, 8 months ago by greggman
Modified:
8 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -8 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 5 chunks +13 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 6 chunks +84 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
greggman
Hey Mo, PTAL
8 years, 8 months ago (2012-04-26 23:12:14 UTC) #1
Zhenyao Mo
https://chromiumcodereview.appspot.com/10246004/diff/1/gpu/command_buffer/service/program_manager.cc File gpu/command_buffer/service/program_manager.cc (right): https://chromiumcodereview.appspot.com/10246004/diff/1/gpu/command_buffer/service/program_manager.cc#newcode271 gpu/command_buffer/service/program_manager.cc:271: return true; Here you should return success instead of ...
8 years, 8 months ago (2012-04-26 23:22:09 UTC) #2
greggman
https://chromiumcodereview.appspot.com/10246004/diff/1/gpu/command_buffer/service/program_manager.cc File gpu/command_buffer/service/program_manager.cc (right): https://chromiumcodereview.appspot.com/10246004/diff/1/gpu/command_buffer/service/program_manager.cc#newcode271 gpu/command_buffer/service/program_manager.cc:271: return true; On 2012/04/26 23:22:09, Zhenyao Mo wrote: > ...
8 years, 8 months ago (2012-04-26 23:41:11 UTC) #3
Zhenyao Mo
LGTM
8 years, 8 months ago (2012-04-27 00:00:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10246004/4001
8 years, 8 months ago (2012-04-27 05:22:56 UTC) #5
commit-bot: I haz the power
Try job failure for 10246004-4001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 05:42:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10246004/16002
8 years, 8 months ago (2012-04-27 17:53:07 UTC) #7
commit-bot: I haz the power
Try job failure for 10246004-16002 (retry) on mac_rel for step "check_deps". It's a second try, ...
8 years, 8 months ago (2012-04-27 18:41:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10246004/16002
8 years, 8 months ago (2012-04-27 22:00:53 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 01:09:56 UTC) #10
Change committed as 134418

Powered by Google App Engine
This is Rietveld 408576698