Used scoped temp dir for download files in DownloadErrorsFile Test.

Used scoped temp dir for download files in DownloadErrorsFile Test.

BUG=122085
R=asanka@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134783

[Randy Smith (Not in Mondays), 2012-04-26 20:34:57]

Asanka: PTAL?

[asanka, 2012-04-26 21:15:09]

LGTM.

Just a suggestion: I think with this change, every test in DownloadTest is now
calling InitialSetup(). Perhaps we should just call it from SetUpOnMainThread().

[Randy Smith (Not in Mondays), 2012-04-29 21:23:54]

On 2012/04/26 21:15:09, asanka wrote:
> LGTM.
> 
> Just a suggestion: I think with this change, every test in DownloadTest is now
> calling InitialSetup(). Perhaps we should just call it from
SetUpOnMainThread().

Asanka: I've implemented the above.  Take another quick look?

[asanka, 2012-04-30 14:49:04]

LGTM++! Thanks.

[commit-bot: I haz the power, 2012-04-30 18:42:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10237010/9001

[commit-bot: I haz the power, 2012-04-30 18:42:06]

Can't apply patch for file chrome/browser/download/download_browsertest.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/download/download_browsertest.cc
Hunk #3 succeeded at 493 (offset -6 lines).
Hunk #4 succeeded at 811 (offset -44 lines).
Hunk #5 succeeded at 857 (offset -44 lines).
Hunk #6 succeeded at 873 (offset -44 lines).
Hunk #7 succeeded at 893 (offset -44 lines).
Hunk #8 succeeded at 926 (offset -44 lines).
Hunk #9 succeeded at 944 (offset -44 lines).
Hunk #10 succeeded at 1002 (offset -44 lines).
Hunk #11 succeeded at 1020 (offset -46 lines).
Hunk #12 succeeded at 1055 (offset -48 lines).
Hunk #13 succeeded at 1094 (offset -49 lines).
Hunk #14 succeeded at 1143 (offset -49 lines).
Hunk #15 succeeded at 1163 (offset -49 lines).
Hunk #16 succeeded at 1189 (offset -49 lines).
Hunk #17 succeeded at 1220 (offset -49 lines).
Hunk #18 succeeded at 1261 (offset -49 lines).
Hunk #19 succeeded at 1293 (offset -49 lines).
Hunk #20 succeeded at 1327 (offset -49 lines).
Hunk #21 succeeded at 1386 (offset -49 lines).
Hunk #22 succeeded at 1455 (offset -49 lines).
Hunk #23 succeeded at 1506 (offset -49 lines).
Hunk #24 succeeded at 1543 (offset -49 lines).
Hunk #25 succeeded at 1566 (offset -49 lines).
Hunk #26 succeeded at 1593 (offset -49 lines).
Hunk #27 succeeded at 1619 (offset -49 lines).
Hunk #28 succeeded at 1649 (offset -49 lines).
Hunk #29 succeeded at 1673 (offset -49 lines).
Hunk #30 succeeded at 1703 (offset -49 lines).
Hunk #31 succeeded at 1732 (offset -49 lines).
Hunk #32 succeeded at 1759 (offset -49 lines).
Hunk #33 succeeded at 1793 (offset -49 lines).
Hunk #34 succeeded at 1918 (offset -49 lines).
Hunk #35 succeeded at 1949 (offset -49 lines).
Hunk #36 succeeded at 1981 (offset -49 lines).
Hunk #37 succeeded at 2042 (offset -49 lines).
Hunk #38 succeeded at 2164 (offset -49 lines).
Hunk #39 succeeded at 2370 (offset -49 lines).
Hunk #40 FAILED at 2448.
1 out of 40 hunks FAILED -- saving rejects to file
chrome/browser/download/download_browsertest.cc.rej

[commit-bot: I haz the power, 2012-05-01 19:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10237010/22002

[commit-bot: I haz the power, 2012-05-01 21:44:09]

Change committed as 134783