Added RefreshPolicies to PolicyService.

chrome/browser/resources/policy.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This variable structure is here to document the structure that the template
  * expects to correctly populate the page.
  */
 var policyDataFormat = {
   // Whether any of the policies in 'policies' have a value.
   'anyPoliciesSet': true,
 
-  // False if the policy information is being sent due to an initial page load
-  // and true if it is being sent due to a change of policy values.
-  'isPolicyUpdate': false,
   'policies': [
     {
       'level': 'managed',
       'name': 'AllowXYZ',
       'set': true,
       'scope': 'Machine',
       'status': 'ok',
       'value': true
     }
   ],
@@ skipping 22 matching lines @@
   cr.addSingletonGetter(Policy);
 
   Policy.prototype = {
     /**
      * True if none of the received policies are actually set, false otherwise.
      * @type {boolean}
      */
     noActivePolicies_: false,
 
     /**
+     * True if the UI is waiting for the initial policy data to be provided by
+     * the PolicyUIHandler.
+     * @type {boolean}
+     */
+    waitingForInitialData_: true,
+
+    /**
      * The current search term for filtering of the policy table.
      * @type {string}
      * @private
      */
     searchTerm_: '',
 
     /**
      * Takes the |policyData| argument and populates the page with this data. It
      * expects an object structure like the policyDataFormat above.
      * @param {Object} policyData Detailed info about policies.
@@ skipping 141 matching lines @@
   Policy.requestData = function() {
     chrome.send('requestData');
   };
 
   /**
    * Called by the C++ PolicyUIHandler when it has the requested data.
    * @param {Object} policyData The policy information in the format described
    * by the policyDataFormat.
    */
   Policy.returnData = function(policyData) {
-    if (policyData.isPolicyUpdate) {
-      Policy.getInstance().collapseExpandedCells();
-      Policy.getInstance().renderTemplate(policyData);
-      Policy.getInstance().updatePolicyVisibility();
+    var policy = Policy.getInstance();
+    var isFirstLoad = policy.waitingForInitialData_;
+    policy.waitingForInitialData_ = false;
 
-      $('fetch-policies-button').disabled = false;
+    if (isFirstLoad) {
+      policy.renderTemplate(policyData);
     } else {
-      Policy.getInstance().renderTemplate(policyData);
+      policy.collapseExpandedCells();
+      policy.renderTemplate(policyData);
+      policy.updatePolicyVisibility();

[Mattias Nissler (ping if slow), 2012/04/27 12:52:58]

Any reason why we need the isFirstLoad distinction here? Can't we just run the
else branch always?

[Joao da Silva, 2012/04/27 13:26:43]

I didn't look at first. This was the original code, from
http://codereview.chromium.org/7828042/diff/1/chrome/browser/resources/policy....
collapseExpandedCells() and updatePolicyVisibility() can both handle an empty
template, and I've verified that it works, so I've removed this flag too.

     }
   };
 
   /**
+   * Called by the C++ PolicyUIHandler when a requested policy refresh has
+   * completed.
+   */
+  Policy.refreshDone = function() {
+    $('fetch-policies-button').disabled = false;
+  };
+
+  /**
    * Asks the C++ PolicyUIHandler to re-fetch policy information.
    */
   Policy.triggerPolicyFetch = function() {
     chrome.send('fetchPolicy');
   };
 
   /**
    * Determines whether a policy should be visible or not.
    * @param {Object} policy An entry in the 'policies' array given by the above
    * PolicyDataFormat.
@@ skipping 28 matching lines @@
   // Export
   return {
     Policy: Policy
   };
 });
 
 var Policy = policies.Policy;
 
 // Get data and have it displayed upon loading.
 document.addEventListener('DOMContentLoaded', policies.Policy.initialize);