[Sync] Add support for automatic enabling of syncing tab favicons.

[Sync] Add support for automatic enabling of syncing tab favicons.

We add the sync_tab_favicons field to the nigori node and add support
for automatically enabling the feature when we receive a new nigori node.
Once we do enable the feature, the browser will only start writing favicons
after the next restart.

BUG=92728
TEST=using python testserver to enable sync tab favicons, then restarting.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134184

[Nicolas Zea, 2012-04-26 21:40:18]

PTAL

[tim (not reviewing), 2012-04-26 22:25:32]

LGTM with naming nit

https://chromiumcodereview.appspot.com/10235013/diff/1001/sync/util/sync_expe...
File sync/util/sync_experiments.h (right):

https://chromiumcodereview.appspot.com/10235013/diff/1001/sync/util/sync_expe...
sync/util/sync_experiments.h:14: struct SyncExperiments {
Since this is already in browser_sync, I think just Experiments is sufficient.

[Nicolas Zea, 2012-04-26 22:50:30]

https://chromiumcodereview.appspot.com/10235013/diff/1001/sync/util/sync_expe...
File sync/util/sync_experiments.h (right):

https://chromiumcodereview.appspot.com/10235013/diff/1001/sync/util/sync_expe...
sync/util/sync_experiments.h:14: struct SyncExperiments {
On 2012/04/26 22:25:32, timsteele wrote:
> Since this is already in browser_sync, I think just Experiments is sufficient.


Done.

[commit-bot: I haz the power, 2012-04-26 22:51:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/10235013/9015

[commit-bot: I haz the power, 2012-04-27 00:27:27]

Change committed as 134184