Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: remoting/protocol/libjingle_transport_factory.h

Issue 10233021: Move PortAllocator creation out of LibjingleTransportFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_session_unittest.cc ('k') | remoting/protocol/libjingle_transport_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/libjingle_transport_factory.h
diff --git a/remoting/protocol/libjingle_transport_factory.h b/remoting/protocol/libjingle_transport_factory.h
index a3d449544567982dca5dd3b49c8d5bf6e4d4bd9c..0ea8fc6594ef277e663791fe4f88220faf34a057 100644
--- a/remoting/protocol/libjingle_transport_factory.h
+++ b/remoting/protocol/libjingle_transport_factory.h
@@ -7,6 +7,10 @@
#include "remoting/protocol/transport.h"
+namespace cricket {
+class PortAllocator;
+} // namespace cricket
+
namespace talk_base {
class NetworkManager;
class PacketSocketFactory;
@@ -17,7 +21,16 @@ namespace protocol {
class LibjingleTransportFactory : public TransportFactory {
public:
+ LibjingleTransportFactory(
+ scoped_ptr<talk_base::NetworkManager> network_manager,
+ scoped_ptr<talk_base::PacketSocketFactory> socket_factory,
+ scoped_ptr<cricket::PortAllocator> port_allocator,
+ bool incoming_only);
+
+ // Creates BasicNetworkManager, BasicPacketSocketFactory and
+ // BasicPortAllocator.
LibjingleTransportFactory();
+
virtual ~LibjingleTransportFactory();
virtual scoped_ptr<StreamTransport> CreateStreamTransport() OVERRIDE;
@@ -26,6 +39,8 @@ class LibjingleTransportFactory : public TransportFactory {
private:
scoped_ptr<talk_base::NetworkManager> network_manager_;
scoped_ptr<talk_base::PacketSocketFactory> socket_factory_;
+ scoped_ptr<cricket::PortAllocator> port_allocator_;
+ bool incoming_only_;
DISALLOW_COPY_AND_ASSIGN(LibjingleTransportFactory);
};
« no previous file with comments | « remoting/protocol/jingle_session_unittest.cc ('k') | remoting/protocol/libjingle_transport_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698