Move PortAllocator creation out of LibjingleTransportFactory.

remoting/protocol/pepper_transport_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/pepper_transport_factory.h"
 
 #include "base/bind.h"
 #include "crypto/hmac.h"
 #include "jingle/glue/utils.h"
 #include "net/base/cert_status_flags.h"
@@ skipping 131 matching lines @@
   if (transport->SetProperty(PP_TRANSPORTPROPERTY_TCP_NO_DELAY,
                              pp::Var(true)) != PP_OK) {
     LOG(ERROR) << "Failed to set TCP_NODELAY";
   }
 
   if (transport->SetProperty(PP_TRANSPORTPROPERTY_TCP_ACK_DELAY,
                              pp::Var(kTcpAckDelayMilliseconds)) != PP_OK) {
     LOG(ERROR) << "Failed to set TCP ACK delay.";
   }
 
-  if (config_.nat_traversal_mode == TransportConfig::NAT_TRAVERSAL_ENABLED) {

[Wez, 2012/04/27 17:58:51]

This test seems to be going away because TransportConfig no longer knows about
NAT traversal; NAT traversal has been pushed up to be a host-side setting.
What's the rationale for that?

[Sergey Ulanov, 2012/04/27 22:51:14]

Currently TransportConfig comes from the signaling layer when creating a
transport, and I don't think that the signaling layer needs to worry about NAT
traversal. It is still possible to enable/disable NAT traversal when creating
transport layer. This particular code is used on client side only and I plan to
remove it anyway (after we migrate to the UDP API), so it's not necessary to be
able to disable NAT traversal here. Ideally STUN/Relay configuration should be
fetched outside of JingleSessionManager - I added TODO to fix that. 

-    if (transport->SetProperty(
-            PP_TRANSPORTPROPERTY_STUN_SERVER,
-            pp::Var(config_.stun_server)) != PP_OK) {
-      LOG(ERROR) << "Failed to set STUN server.";
-    }
+  if (transport->SetProperty(
+          PP_TRANSPORTPROPERTY_STUN_SERVER,
+          pp::Var(config_.stun_server)) != PP_OK) {
+    LOG(ERROR) << "Failed to set STUN server.";
+  }
 
-    if (transport->SetProperty(
-            PP_TRANSPORTPROPERTY_RELAY_SERVER,
-            pp::Var(config_.relay_server)) != PP_OK) {
-      LOG(ERROR) << "Failed to set relay server.";
-    }
+  if (transport->SetProperty(
+          PP_TRANSPORTPROPERTY_RELAY_SERVER,
+          pp::Var(config_.relay_server)) != PP_OK) {
+    LOG(ERROR) << "Failed to set relay server.";
+  }
 
-    if (transport->SetProperty(
-            PP_TRANSPORTPROPERTY_RELAY_USERNAME,
-            pp::Var("1")) != PP_OK) {
-      LOG(ERROR) << "Failed to set relay username.";
-    }
+  if (transport->SetProperty(
+          PP_TRANSPORTPROPERTY_RELAY_USERNAME,
+          pp::Var("1")) != PP_OK) {
+    LOG(ERROR) << "Failed to set relay username.";
+  }
 
-    if (transport->SetProperty(
-            PP_TRANSPORTPROPERTY_RELAY_PASSWORD,
-            pp::Var(config_.relay_token)) != PP_OK) {
-      LOG(ERROR) << "Failed to set relay token.";
-    }
+  if (transport->SetProperty(
+          PP_TRANSPORTPROPERTY_RELAY_PASSWORD,
+          pp::Var(config_.relay_token)) != PP_OK) {
+    LOG(ERROR) << "Failed to set relay token.";
+  }
 
-    if (transport->SetProperty(
-            PP_TRANSPORTPROPERTY_RELAY_MODE,
-            pp::Var(PP_TRANSPORTRELAYMODE_GOOGLE)) != PP_OK) {
-      LOG(ERROR) << "Failed to set relay mode.";
-    }
+  if (transport->SetProperty(
+          PP_TRANSPORTPROPERTY_RELAY_MODE,
+          pp::Var(PP_TRANSPORTRELAYMODE_GOOGLE)) != PP_OK) {
+    LOG(ERROR) << "Failed to set relay mode.";
   }
 
   if (transport->SetProperty(PP_TRANSPORTPROPERTY_DISABLE_TCP_TRANSPORT,
                              pp::Var(true)) != PP_OK) {
     LOG(ERROR) << "Failed to set DISABLE_TCP_TRANSPORT flag.";
   }
 
   channel_ = new PepperTransportSocketAdapter(transport, name_, this);
   owned_channel_.reset(channel_);
 
@@ skipping 95 matching lines @@
 }
 
 scoped_ptr<DatagramTransport>
 PepperTransportFactory::CreateDatagramTransport() {
   NOTIMPLEMENTED();
   return scoped_ptr<DatagramTransport>(NULL);
 }
 
 }  // namespace protocol
 }  // namespace remoting