Issue 10233: Fix CALL_NON_FUNCTION. If a builtin is not resolved at runtime (happened at b...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10233: Fix CALL_NON_FUNCTION. If a builtin is not resolved at runtime (happened at b... (Closed)

Created:
12 years, 1 month ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix CALL_NON_FUNCTION. Using two flags to specify the state of targets: 1) FixupIsPCRelative specifies where to patch (relative to pc or at pc); 2) FixupUseCodeObject specifies what to patch (code object or start address). Committed: http://code.google.com/p/v8/source/detail?r=727

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
M	src/bootstrapper.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+12 lines, -3 lines	2 comments	Download
M	src/codegen-arm.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/macro-assembler-arm.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/macro-assembler-ia32.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

Can you take a look at the second version with your offline comments incorporated?

12 years, 1 month ago (2008-11-10 22:30:15 UTC) #2

iposva

LGTM -Ivan PS. Does it lint? http://codereview.chromium.org/10233/diff/205/208 File src/bootstrapper.cc (right): http://codereview.chromium.org/10233/diff/205/208#newcode218 Line 218: ASSERT(is_pc_relative); Please ...

12 years, 1 month ago (2008-11-10 22:38:57 UTC) #3

Feng Qian

12 years, 1 month ago (2008-11-11 18:36:40 UTC) #4

Forgot to publish my reply.

http://codereview.chromium.org/10233/diff/205/208
File src/bootstrapper.cc (right):

http://codereview.chromium.org/10233/diff/205/208#newcode218
Line 218: ASSERT(is_pc_relative);
As we discussed, current IA32 and ARM can only have 3 states in 4 combined
states. No logic reason that an address has to be pc relative.

On 2008/11/10 22:38:57, iposva wrote:
> Please add a comment why this assert is necessary. We just discussed this 5
> minutes ago and it was already unclear to me.

Expand Messages | Collapse Messages