Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10232010: DownloadUrlParameters (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/drag_download_file.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index c7ac5bf307b1db4fe497ca0d6d97ca24a677ffa3..269aedef3d0c3b8328daa969989bf1b6a1bd8792 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -42,6 +42,7 @@
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/devtools_agent_host_registry.h"
#include "content/public/browser/download_manager.h"
+#include "content/public/browser/download_url_parameters.h"
#include "content/public/browser/invalidate_type.h"
#include "content/public/browser/javascript_dialogs.h"
#include "content/public/browser/load_notification_details.h"
@@ -129,6 +130,7 @@ using content::DevToolsAgentHostRegistry;
using content::DevToolsManagerImpl;
using content::DownloadItem;
using content::DownloadManager;
+using content::DownloadUrlParameters;
using content::GlobalRequestID;
using content::HostZoomMap;
using content::InterstitialPage;
@@ -144,9 +146,9 @@ using content::RenderWidgetHost;
using content::RenderWidgetHostView;
using content::RenderWidgetHostViewPort;
using content::ResourceDispatcherHostImpl;
+using content::SSLStatus;
using content::SessionStorageNamespace;
using content::SiteInstance;
-using content::SSLStatus;
using content::UserMetricsAction;
using content::WebContents;
using content::WebContentsObserver;
@@ -2686,14 +2688,14 @@ void WebContentsImpl::SaveURL(const GURL& url,
}
content::DownloadSaveInfo save_info;
save_info.prompt_for_save_location = true;
- dlm->DownloadUrl(url,
- referrer,
- "",
- true, // prefer_cache
- post_id,
- save_info,
- this,
- DownloadManager::OnStartedCallback());
+ scoped_ptr<DownloadUrlParameters> params(
+ DownloadUrlParameters::FromWebContents(this, url, save_info));
+ params->set_referrer(referrer);
+ params->set_post_id(post_id);
+ params->set_prefer_cache(true);
+ if (post_id >= 0)
+ params->set_method("POST");
+ dlm->DownloadUrl(params.Pass());
}
void WebContentsImpl::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
« no previous file with comments | « content/browser/download/drag_download_file.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698