DownloadUrlParameters

chrome/browser/download/download_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 50 matching lines @@
 #include "content/test/test_file_error_injector.h"
 #include "content/test/test_navigation_observer.h"
 #include "net/base/net_util.h"
 #include "net/test/test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 using content::DownloadItem;
 using content::DownloadManager;
 using content::DownloadPersistentStoreInfo;
+using content::DownloadUrlParameters;
 using content::WebContents;
 
 namespace {
 
 // IDs and paths of CRX files used in tests.
 const char kGoodCrxId[] = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
 const FilePath kGoodCrxPath(FILE_PATH_LITERAL("extensions/good.crx"));
 
 const char kLargeThemeCrxId[] = "pjpgmfcmabopnnfonnhmdjglfpjjfkbf";
 const FilePath kLargeThemePath(FILE_PATH_LITERAL("extensions/theme2.crx"));
@@ skipping 585 matching lines @@
 
     if (download_info.download_method == DOWNLOAD_DIRECT) {
       // Go directly to download.  Don't wait for navigation.
       content::DownloadSaveInfo save_info;
       // NOTE: |prompt_for_save_location| may change during the download.
       save_info.prompt_for_save_location = false;
 
       scoped_refptr<DownloadTestItemCreationObserver> creation_observer(
           new DownloadTestItemCreationObserver);
 
-      DownloadManagerForBrowser(browser())->DownloadUrl(
-          url, GURL(""), "", false, -1, save_info, web_contents,
-          creation_observer->callback());
+      DownloadUrlParameters* params = DownloadUrlParameters::FromWebContents(
+          web_contents, url, save_info);
+      params->set_callback(creation_observer->callback());
+      DownloadManagerForBrowser(browser())->DownloadUrl(params);
 
       // Wait until the item is created, or we have determined that it
       // won't be.
       creation_observer->WaitForDownloadItemCreation();
 
       int32 invalid_id = content::DownloadId::Invalid().local();
       EXPECT_EQ(download_info.show_download_item,
                 creation_observer->succeeded());
       if (download_info.show_download_item) {
         EXPECT_EQ(net::OK, creation_observer->error());
@@ skipping 1278 matching lines @@
   ASSERT_TRUE(web_contents);
 
   DownloadTestObserver* observer(
       new DownloadTestObserverTerminal(
           DownloadManagerForBrowser(browser()), 1,
           false,                   // Ignore select file.
           DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
   content::DownloadSaveInfo save_info;
   save_info.prompt_for_save_location = true;
   DownloadManagerForBrowser(browser())->DownloadUrl(
-      url, GURL(""), "", false, -1, save_info, web_contents,
-      DownloadManager::OnStartedCallback());
+      DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
   observer->WaitForFinished();
   EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
   CheckDownloadStates(1, DownloadItem::COMPLETE);
   EXPECT_TRUE(observer->select_file_dialog_seen());
 
   // Check state.
   EXPECT_EQ(1, browser()->tab_count());
   ASSERT_TRUE(CheckDownload(browser(), file, file));
   EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
 }
 
 IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
   ASSERT_TRUE(InitialSetup(false));
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
   GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
 
   WebContents* web_contents = browser()->GetSelectedWebContents();
   ASSERT_TRUE(web_contents);
 
   ScopedTempDir other_directory;
   ASSERT_TRUE(other_directory.CreateUniqueTempDir());
   FilePath target_file_full_path
       = other_directory.path().Append(file.BaseName());
   content::DownloadSaveInfo save_info;
   save_info.file_path = target_file_full_path;
 
   DownloadTestObserver* observer(CreateWaiter(browser(), 1));
   DownloadManagerForBrowser(browser())->DownloadUrl(
-      url, GURL(""), "", false, -1, save_info, web_contents,
-      DownloadManager::OnStartedCallback());
+      DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
   observer->WaitForFinished();
   EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
 
   // Check state.
   EXPECT_EQ(1, browser()->tab_count());
   ASSERT_TRUE(CheckDownloadFullPaths(browser(),
                                      target_file_full_path,
                                      OriginFile(file)));
 
   // Temporary downloads won't be visible.
@@ skipping 457 matching lines @@
   ASSERT_TRUE(web_contents);
   scoped_refptr<DownloadTestItemCreationObserver> creation_observer(
       new DownloadTestItemCreationObserver);
   // Only for cleanup if a download is actually created.
   DownloadTestObserverTerminal backup_observer(
       DownloadManagerForBrowser(browser()),
       1,
       false,
       DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
 
-  DownloadManagerForBrowser(browser())->DownloadUrl(
-      url, GURL(), "", false, -1, content::DownloadSaveInfo(),
-      web_contents, creation_observer->callback());
+  DownloadUrlParameters* params = DownloadUrlParameters::FromWebContents(
+      web_contents, url, content::DownloadSaveInfo());
+  params->set_callback(creation_observer->callback());
+  DownloadManagerForBrowser(browser())->DownloadUrl(params);
 
   creation_observer->WaitForDownloadItemCreation();
 
   EXPECT_FALSE(creation_observer->succeeded());
   EXPECT_EQ(net::ERR_DISALLOWED_URL_SCHEME, creation_observer->error());
   EXPECT_EQ(content::DownloadId::Invalid(), creation_observer->download_id());
   downloads.clear();
   GetDownloads(browser(), &downloads);
   EXPECT_EQ(0u, downloads.size());
 
   if (creation_observer->succeeded()) {
     // Wait until the download is done.  We don't care how it's finished.
     backup_observer.WaitForFinished();
   }
   DownloadManagerForBrowser(browser())->RemoveAllDownloads();
 }