Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10230005: New Autofill UI uses ID for password (Closed)

Created:
8 years, 8 months ago by csharp
Modified:
8 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

New Autofill UI uses ID for password The new Autofill UI uses field IDs to determine which values should be handled by the password manager or the default Autofill manager. BUG=51644 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134266

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M chrome/browser/autofill/autofill_external_delegate.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/autofill/password_autofill_manager.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/autofill/password_autofill_manager.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/autofill/password_autofill_manager_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
csharp
Moving the password ID code into it's own cl.
8 years, 8 months ago (2012-04-26 15:38:04 UTC) #1
Ilya Sherman
lgtm
8 years, 8 months ago (2012-04-26 18:11:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10230005/3001
8 years, 8 months ago (2012-04-26 18:12:29 UTC) #3
commit-bot: I haz the power
Try job failure for 10230005-3001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=20217 Step "update" is always ...
8 years, 8 months ago (2012-04-26 18:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10230005/3001
8 years, 8 months ago (2012-04-26 18:23:52 UTC) #5
commit-bot: I haz the power
Try job failure for 10230005-3001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-26 21:22:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10230005/3001
8 years, 8 months ago (2012-04-27 13:03:41 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-27 14:25:13 UTC) #8
Change committed as 134266

Powered by Google App Engine
This is Rietveld 408576698