Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10228020: Propagate gpu debugging flags in guest mode (Closed)

Created:
8 years, 8 months ago by sheu
Modified:
8 years, 7 months ago
Reviewers:
James Cook, Will Drewry, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

Propagate gpu debugging flags in guest mode Guest logins in ChromeOS cause Chrome to restart itself through dbus. Some debugging flags aren't propagated through the restart -- these include: * --disable-gpu-watchdog * --no-sandbox * --gpu-startup-dialog * --renderer-startup-dialog Add these to the list of propagated flags. Change-Id: I977eabe322447174ca7281137838012d042bac6f BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zel
lgtm
8 years, 7 months ago (2012-04-30 18:58:05 UTC) #1
James Cook
LGTM. Sorry for the delay - I didn't get a notification email for this change ...
8 years, 7 months ago (2012-04-30 18:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/10228020/1
8 years, 7 months ago (2012-04-30 19:08:09 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 20:46:42 UTC) #4
Change committed as 134592

Powered by Google App Engine
This is Rietveld 408576698