Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: media/base/buffers.h

Issue 10228017: Add initial implementation of SourceBufferStream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/buffers.cc » ('j') | media/base/data_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/buffers.h
diff --git a/media/base/buffers.h b/media/base/buffers.h
index f4e42642b4f240ce961d987094d59e80365c5dcb..5afe79e2d05ba4bbe88d168193f97c90c5db0d2c 100644
--- a/media/base/buffers.h
+++ b/media/base/buffers.h
@@ -73,14 +73,20 @@ class MEDIA_EXPORT Buffer : public base::RefCountedThreadSafe<Buffer> {
duration_ = duration;
}
+ // TODO(vrk): Only ChunkDemuxer and friends care about keyframes.
+ // Put keyframe stuff inside a derived class of Buffer?
acolwell GONE FROM CHROMIUM 2012/04/29 18:13:06 I think you should remove this TODO. ISTM if we re
vrk (LEFT CHROMIUM) 2012/05/01 22:51:13 Done.
+ bool IsKeyframe() const { return is_keyframe_; }
+
protected:
friend class base::RefCountedThreadSafe<Buffer>;
Buffer(base::TimeDelta timestamp, base::TimeDelta duration);
+ Buffer(base::TimeDelta timestamp, base::TimeDelta duration, bool is_keyframe);
acolwell GONE FROM CHROMIUM 2012/04/29 18:13:06 I think we should be able to get away with just ad
vrk (LEFT CHROMIUM) 2012/05/01 22:51:13 Done, CL here: https://chromiumcodereview.appspot.
virtual ~Buffer();
private:
base::TimeDelta timestamp_;
base::TimeDelta duration_;
+ bool is_keyframe_;
DISALLOW_COPY_AND_ASSIGN(Buffer);
};
« no previous file with comments | « no previous file | media/base/buffers.cc » ('j') | media/base/data_buffer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698