Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 10228006: Extensions: Add missing SendResponse to API call. (Closed)

Created:
8 years, 8 months ago by bryeung
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Extensions: Add missing SendResponse to API call. GetDevicesWithServiceName was missing a SendResponse when there were no bluetooth devices known to the system. TEST=manually via my demo app BUG=119473 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bryeung
One line fix (plus a bit of style clean-up local to the diff).
8 years, 8 months ago (2012-04-25 15:08:02 UTC) #1
asargent_no_longer_on_chrome
lgtm
8 years, 8 months ago (2012-04-25 17:58:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryeung@chromium.org/10228006/1
8 years, 8 months ago (2012-04-25 18:06:54 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 19:53:45 UTC) #4
Change committed as 133960

Powered by Google App Engine
This is Rietveld 408576698