Issue 10227001: Simplify ScheduleDelayedWork implementation on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10227001: Simplify ScheduleDelayedWork implementation on Mac (Closed)

Created:
8 years, 8 months ago by stuartmorgan

Modified:
8 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, erikwright (departed), sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify ScheduleDelayedWork implementation on Mac Instead of round-tripping through Time::Exploded, which seems to be a legacy of the method having a different argument type, just calculate the new timer firing time directly from the difference in time ticks. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133916

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -22 lines)			Patch
	M	base/message_pump_mac.mm	View		1 chunk	+2 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10227001/1

8 years, 8 months ago (2012-04-25 13:56:18 UTC) #3

Change committed as 133916

Expand Messages | Collapse Messages