Add a learn more link to password generation bubble to point to a help page.

chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/password_generation_bubble_gtk.h"
 
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/platform_util.h"

[Garrett Casto, 2012/04/26 21:45:15]

Why did you add this?

[zysxqn, 2012/04/26 23:46:25]

Forgot to remove this after I decided not to use some functions in it. Removed.

+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/gtk/bubble/bubble_gtk.h"
+#include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"
+#include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/gtk/theme_service_gtk.h"
 #include "chrome/common/autofill_messages.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/browser/render_view_host.h"
+#include "grit/generated_resources.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
+#include "ui/base/l10n/l10n_util.h"
 
 const int kContentBorder = 4;
 const int kHorizontalSpacing = 4;
 
 PasswordGenerationBubbleGtk::PasswordGenerationBubbleGtk(
     const gfx::Rect& anchor_rect,
     GtkWidget* anchor_widget,
     Profile* profile,
     content::RenderViewHost* render_view_host)
-    : render_view_host_(render_view_host) {
+    : profile_(profile), render_view_host_(render_view_host) {
   // TODO(gcasto): Localize text after we have finalized the UI.
   // crbug.com/118062
   GtkWidget* content = gtk_vbox_new(FALSE, 5);
 
-  // We have two lines of content. The first is just the title,
+  // We have two lines of content. The first is the title and learn more link.
   GtkWidget* title_line = gtk_hbox_new(FALSE,  0);
   GtkWidget* title = gtk_label_new("Password Suggestion");
   gtk_box_pack_start(GTK_BOX(title_line), title, FALSE, FALSE, 0);
+  GtkWidget* learn_more_link = gtk_chrome_link_button_new(
+      l10n_util::GetStringUTF8(IDS_LEARN_MORE).c_str());
+  gtk_button_set_alignment(GTK_BUTTON(learn_more_link), 0.0, 0.5);
+  gtk_box_pack_start(GTK_BOX(title_line),
+                     gtk_util::IndentWidget(learn_more_link),
+                     FALSE, FALSE, 0);
+  g_signal_connect(learn_more_link, "clicked",

[Garrett Casto, 2012/04/26 21:45:15]

nit: I would put all the callback registrations together.

[zysxqn, 2012/04/26 23:46:25]

Done.

+                   G_CALLBACK(OnLearnMoreLinkClickedThunk), this);
 
   // The second contains the password in a text field and an accept button.
   GtkWidget* password_line = gtk_hbox_new(FALSE, kHorizontalSpacing);
   text_field_ = gtk_entry_new();
   gtk_entry_set_text(GTK_ENTRY(text_field_),
                      password_generator_.Generate().c_str());
   gtk_entry_set_max_length(GTK_ENTRY(text_field_), 15);
   GtkWidget* accept_button = gtk_button_new_with_label("Try It");
   gtk_box_pack_start(GTK_BOX(password_line), text_field_, TRUE, TRUE, 0);
   gtk_box_pack_start(GTK_BOX(password_line), accept_button, TRUE, TRUE, 0);
 
   gtk_container_set_border_width(GTK_CONTAINER(content), kContentBorder);
   gtk_box_pack_start(GTK_BOX(content), title_line, TRUE, TRUE, 0);
   gtk_box_pack_start(GTK_BOX(content), password_line, TRUE, TRUE, 0);
 
   bubble_ = BubbleGtk::Show(anchor_widget,
                             &anchor_rect,
                             content,
                             BubbleGtk::ARROW_LOCATION_TOP_LEFT,
                             true,  // match_system_theme
                             true,  // grab_input
-                            ThemeServiceGtk::GetFrom(profile),
+                            ThemeServiceGtk::GetFrom(profile_),
                             NULL);  // delegate
 
   g_signal_connect(content, "destroy",
                    G_CALLBACK(&OnDestroyThunk), this);
   g_signal_connect(accept_button, "clicked",
                    G_CALLBACK(&OnAcceptClickedThunk), this);
 }
 
 PasswordGenerationBubbleGtk::~PasswordGenerationBubbleGtk() {}
 
 void PasswordGenerationBubbleGtk::OnDestroy(GtkWidget* widget) {
   // We are self deleting, we have a destroy signal setup to catch when we are
   // destroyed (via the BubbleGtk being destroyed), and delete ourself.
   delete this;
 }
 
 void PasswordGenerationBubbleGtk::OnAcceptClicked(GtkWidget* widget) {
   render_view_host_->Send(new AutofillMsg_GeneratedPasswordAccepted(
       render_view_host_->GetRoutingID(),
       UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(text_field_)))));
   bubble_->Close();
 }
+
+void PasswordGenerationBubbleGtk::OnLearnMoreLinkClicked(GtkButton* button) {
+  // We open a new browser window so the Options dialog doesn't get lost behind
+  // other windows.
+  Browser* browser = Browser::Create(profile_);

[Garrett Casto, 2012/04/26 21:45:15]

Don't open a new window, open a new tab in the current window and switch to that
tab. Popup windows are annoying.

This might change with the above change, but you need to destroy the bubble,
either explicitly or by it losing focus. Currently if the new window happens to
overlap the bubble, you can see the bubble on top of the new window until you
click on something.

[zysxqn, 2012/04/26 23:46:25]

Changed to open a new tab in the same window. 

My question is whether we should close the bubble. I think a common use case
would be: user click password field -> bubble shows -> user click learn more ->
user decided to use auto password generation and close the new tab -> user
returns to the sign up page and expect to click "try it" but the bubble has gone
now. The user need to move the mouse elsewhere and back to the password field to
trigger "focus change" callback.

One solution is not to close the bubble, but like you said it looks a little
weird to see the bubble while reading the help page. 

Any ideas?

+  browser->AddSelectedTabWithURL(
+      GURL(chrome::kAutoPasswordGenerationLearnMoreURL),
+      content::PAGE_TRANSITION_LINK);
+  browser->window()->Show();
+}