Issue 10223019: Add ClientDimensions message to control channel.

Issue 10223019: Add ClientDimensions message to control channel. (Closed)

Created:
8 years, 8 months ago by Wez

Modified:
8 years, 8 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ClientDimensions message to control channel. This allows the client to indicate the tab dimensions so the host can resize to match. BUG=110212 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134180

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rename SetClientDimensions to NotifyClientDimensions. #

Patch Set 3 : Add missing HostMockStub method. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -8 lines)			Patch
M	remoting/host/client_session.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/host/client_session.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	remoting/proto/control.proto	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	remoting/proto/internal.proto	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/protocol/client_control_dispatcher.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/protocol/client_control_dispatcher.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	remoting/protocol/host_control_dispatcher.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/protocol/host_stub.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	remoting/protocol/protocol_mock_objects.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM with one naming suggestion. https://chromiumcodereview.appspot.com/10223019/diff/1/remoting/protocol/host_stub.h File remoting/protocol/host_stub.h (right): https://chromiumcodereview.appspot.com/10223019/diff/1/remoting/protocol/host_stub.h#newcode26 remoting/protocol/host_stub.h:26: virtual void SetClientDimensions(const ClientDimensions& ...

8 years, 8 months ago (2012-04-26 01:36:36 UTC) #2

Wez

https://chromiumcodereview.appspot.com/10223019/diff/1/remoting/protocol/host_stub.h File remoting/protocol/host_stub.h (right): https://chromiumcodereview.appspot.com/10223019/diff/1/remoting/protocol/host_stub.h#newcode26 remoting/protocol/host_stub.h:26: virtual void SetClientDimensions(const ClientDimensions& dimensions) = 0; On 2012/04/26 ...

8 years, 8 months ago (2012-04-26 17:32:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10223019/4001

8 years, 8 months ago (2012-04-26 17:33:37 UTC) #4

commit-bot: I haz the power

Try job failure for 10223019-4001 (retry) on mac_rel for step "compile" (clobber build). It's a ...

8 years, 8 months ago (2012-04-26 18:03:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10223019/8003

8 years, 8 months ago (2012-04-26 22:32:01 UTC) #6

Change committed as 134180

Expand Messages | Collapse Messages