ppapi Graphics2d should invalidate all changes without clipping to visible area.

ppapi Graphics2d should invalidate all changes without clipping to visible area.

Currently the flush operation assumes that WebKit will request the ppapi plugin
to repaint any newly exposed regions, and so it only invalidates the visible
portion of changes. However, for accelerated compositing, this behavior is not
correct. This patch rearranges the logic to work for both accelerated and
non-accelerated compositing.

BUG=122860
TEST=tested manually, created crbug.com/125763 for making a unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134755

[Wez, 2012-04-26 21:13:29]

http://codereview.chromium.org/10223009/diff/1/webkit/plugins/ppapi/ppb_graph...
File webkit/plugins/ppapi/ppb_graphics_2d_impl.cc (right):

http://codereview.chromium.org/10223009/diff/1/webkit/plugins/ppapi/ppb_graph...
webkit/plugins/ppapi/ppb_graphics_2d_impl.cc:365: // Notify the plugin of the
entire change (op_rect), even if it is
Doesn't this block want to be inside the !op_rect.IsEmpty() block, to match the
original logic?

[shawnsingh, 2012-04-26 22:35:50]

http://codereview.chromium.org/10223009/diff/1/webkit/plugins/ppapi/ppb_graph...
File webkit/plugins/ppapi/ppb_graphics_2d_impl.cc (right):

http://codereview.chromium.org/10223009/diff/1/webkit/plugins/ppapi/ppb_graph...
webkit/plugins/ppapi/ppb_graphics_2d_impl.cc:365: // Notify the plugin of the
entire change (op_rect), even if it is
On 2012/04/26 21:13:29, Wez wrote:
> Doesn't this block want to be inside the !op_rect.IsEmpty() block, to match
the
> original logic?

Yes - thanks.  That should also simplify the ugly nested if-statements,

[shawnsingh, 2012-05-01 17:21:21]

Wez, here's the fixed patch - if this one is good to go, would you be able to
land it, too, since I am not yet a committer?  Thanks very much.

[brettw, 2012-05-01 17:54:18]

lgtm

https://chromiumcodereview.appspot.com/10223009/diff/5002/webkit/plugins/ppap...
File webkit/plugins/ppapi/ppb_graphics_2d_impl.cc (right):

https://chromiumcodereview.appspot.com/10223009/diff/5002/webkit/plugins/ppap...
webkit/plugins/ppapi/ppb_graphics_2d_impl.cc:357:
PP_ToGfxRect(bound_instance_->view_data().clip_rect).
Indent 4 spaces (maybe "Intersect" will fit then?)

[shawnsingh, 2012-05-01 18:05:49]

Thanks for the review!

[commit-bot: I haz the power, 2012-05-01 18:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/10223009/9002

[commit-bot: I haz the power, 2012-05-01 19:58:02]

Change committed as 134755