Package and load native library in content shell. Add content shell util scripts.

Package and load native library in content shell.  Add content shell util scripts.


BUG=None
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134030

[John Grabowski, 2012-04-25 19:06:16]

jam: content/content_shell.gypi (OWNERS)
tedchoc: content shell changes
yaron: util scripts

nilesh: fyi re: java lib dir changes to be consistent

[Yaron, 2012-04-25 20:25:57]

lgtm with some nits

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_in...
File build/android/adb_install_content_shell (right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_in...
build/android/adb_install_content_shell:7: adb install -r
${CHROME_SRC}/out/Release/content_shell/ContentShell-debug.apk
Is there an env variable we can use for Release?

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_ki...
File build/android/adb_kill_content_shell (right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_ki...
build/android/adb_kill_content_shell:14: echo "Not running Chrome."
Not running Content Shell

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
File
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java
(right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:22:
private final String TAG = "ContentShellActivity";
static

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:98:
private static final String sNativeLibrary = "content_shell_content_view";
since it's constant/final, just make it NATIVE_LIBRARY

[John Grabowski, 2012-04-25 20:41:01]

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_in...
File build/android/adb_install_content_shell (right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_in...
build/android/adb_install_content_shell:7: adb install -r
${CHROME_SRC}/out/Release/content_shell/ContentShell-debug.apk
On 2012/04/25 20:25:57, Yaron wrote:
> Is there an env variable we can use for Release?

If so I'd have to generate this script after gypping (or convert this to a 'make
install'), neither of which is desirable.

If/when we support out/Debug I'll have this install only the newest one.

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_ki...
File build/android/adb_kill_content_shell (right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/build/android/adb_ki...
build/android/adb_kill_content_shell:14: echo "Not running Chrome."
On 2012/04/25 20:25:57, Yaron wrote:
> Not running Content Shell

Done.

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
File
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java
(right):

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:22:
private final String TAG = "ContentShellActivity";
On 2012/04/25 20:25:57, Yaron wrote:
> static

Done.

http://chromiumcodereview.appspot.com/10223007/diff/2001/content/shell/androi...
content/shell/android/java/org/chromium/content_shell/ContentShellActivity.java:98:
private static final String sNativeLibrary = "content_shell_content_view";
On 2012/04/25 20:25:57, Yaron wrote:
> since it's constant/final, just make it NATIVE_LIBRARY

Done.

[Ted C, 2012-04-25 21:18:02]

lgtm

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
File content/content_shell.gypi (right):

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
content/content_shell.gypi:539: 'outputs':
['<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_shell_content_view.so'],
Is libs/armeabi the default directory that the ant files will look in for native
libraries when generating the apks?

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
content/content_shell.gypi:551:
'<(SHARED_LIB_DIR)/libcontent_shell_content_view.so',
change this to:
<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_
     shell_content_view.so

[John Grabowski, 2012-04-25 22:05:58]

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
File content/content_shell.gypi (right):

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
content/content_shell.gypi:539: 'outputs':
['<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_shell_content_view.so'],
On 2012/04/25 21:18:02, Ted C wrote:
> Is libs/armeabi the default directory that the ant files will look in for
native
> libraries when generating the apks?

yes (at least when building for ARM)

http://chromiumcodereview.appspot.com/10223007/diff/1009/content/content_shel...
content/content_shell.gypi:551:
'<(SHARED_LIB_DIR)/libcontent_shell_content_view.so',
On 2012/04/25 21:18:02, Ted C wrote:
> change this to:
> <(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_
>      shell_content_view.so

Done.

[jam, 2012-04-25 22:09:41]

lgtm

[commit-bot: I haz the power, 2012-04-25 23:22:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/10223007/5003

[commit-bot: I haz the power, 2012-04-26 00:48:47]

Change committed as 134030