Make password generation switched by a preference in chrome settings rather than a command line fla…

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 46473c3dd1cfa4b212e8897d8ced44a4d43bc196..a3bef576f894d5ed711320757fd78f677fc6c041 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -243,6 +243,7 @@ void ChromeContentRendererClient::RenderViewCreated(
       new PasswordAutofillManager(render_view);
   AutofillAgent* autofill_agent = new AutofillAgent(render_view,
                                                     password_autofill_manager);
+  new PasswordGenerationManager(render_view);
   PageClickTracker* page_click_tracker = new PageClickTracker(render_view);
   // Note that the order of insertion of the listeners is important.
   // The password_autocomplete_manager takes the first shot at processing the
@@ -260,10 +261,6 @@ void ChromeContentRendererClient::RenderViewCreated(
           switches::kDomAutomationController)) {
     new AutomationRendererHelper(render_view);
   }
-  if (CommandLine::ForCurrentProcess()->HasSwitch(

[Garrett Casto, 2012/05/11 23:01:28]

I would leave this behind a flag for now. I don't want to expose normal users to
possible bugs from password generation while this is still under development. 

[zysxqn, 2012/05/11 23:52:51]

Done.

-          switches::kEnablePasswordGeneration)) {
-    new PasswordGenerationManager(render_view);
-  }
 }
 
 void ChromeContentRendererClient::SetNumberOfViews(int number_of_views) {